From 31925f2245d35ab9cbdf8fc57b98a53cb384ceb0 Mon Sep 17 00:00:00 2001 From: johannes karoff Date: Thu, 1 Feb 2024 15:58:49 +0100 Subject: [PATCH 1/2] Generic error event for EventSource According to MDN the error of an EventSource is a generic Event instead of an ErrorEvent: https://developer.mozilla.org/en-US/docs/Web/API/EventSource/error_event --- dom/src/main/scala/org/scalajs/dom/EventSource.scala | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dom/src/main/scala/org/scalajs/dom/EventSource.scala b/dom/src/main/scala/org/scalajs/dom/EventSource.scala index f1df885af..6ae7e3a85 100644 --- a/dom/src/main/scala/org/scalajs/dom/EventSource.scala +++ b/dom/src/main/scala/org/scalajs/dom/EventSource.scala @@ -41,7 +41,7 @@ class EventSource private[this] extends EventTarget { var onmessage: js.Function1[MessageEvent, _] = js.native - var onerror: js.Function1[ErrorEvent, _] = js.native + var onerror: js.Function1[Event, _] = js.native /** The close() method must abort any instances of the fetch algorithm started for this EventSource object, and must * set the readyState attribute to CLOSED. W3C 2012 From d68dd239d284950ddefae95a4a90522cd47708d4 Mon Sep 17 00:00:00 2001 From: johannes karoff Date: Thu, 1 Feb 2024 16:06:33 +0100 Subject: [PATCH 2/2] update api-reports --- api-reports/2_12.txt | 2 +- api-reports/2_13.txt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/api-reports/2_12.txt b/api-reports/2_12.txt index 8a4251625..bf03dfdaa 100644 --- a/api-reports/2_12.txt +++ b/api-reports/2_12.txt @@ -2157,7 +2157,7 @@ EventSource[JC] def addEventListener[T <: Event](`type`: String, listener: js.Fu EventSource[JC] def addEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], useCapture: Boolean?): Unit EventSource[JC] def close(): Unit EventSource[JC] def dispatchEvent(evt: Event): Boolean -EventSource[JC] var onerror: js.Function1[ErrorEvent, _] +EventSource[JC] var onerror: js.Function1[Event, _] EventSource[JC] var onmessage: js.Function1[MessageEvent, _] EventSource[JC] var onopen: js.Function1[Event, _] EventSource[JC] def readyState: Int diff --git a/api-reports/2_13.txt b/api-reports/2_13.txt index 8a4251625..bf03dfdaa 100644 --- a/api-reports/2_13.txt +++ b/api-reports/2_13.txt @@ -2157,7 +2157,7 @@ EventSource[JC] def addEventListener[T <: Event](`type`: String, listener: js.Fu EventSource[JC] def addEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], useCapture: Boolean?): Unit EventSource[JC] def close(): Unit EventSource[JC] def dispatchEvent(evt: Event): Boolean -EventSource[JC] var onerror: js.Function1[ErrorEvent, _] +EventSource[JC] var onerror: js.Function1[Event, _] EventSource[JC] var onmessage: js.Function1[MessageEvent, _] EventSource[JC] var onopen: js.Function1[Event, _] EventSource[JC] def readyState: Int