Remove observer manager and utils

Author: atoulme

internal/signalfx-agent/pkg/core/config/text.go

@@ -10,14 +10,9 @@
 package observers
 
 import (
-	"fmt"
-
 	log "github.com/sirupsen/logrus"
 
-	"github.com/signalfx/signalfx-agent/pkg/core/config"
-	"github.com/signalfx/signalfx-agent/pkg/core/config/validation"
 	"github.com/signalfx/signalfx-agent/pkg/core/services"
-	"github.com/signalfx/signalfx-agent/pkg/utils"
 )
 
 // Shutdownable describes an observer that has a shutdown routine.  Observers
@@ -56,21 +51,3 @@ type ServiceCallbacks struct {
 	Added   func(services.Endpoint)
 	Removed func(services.Endpoint)
 }
-
-func configureObserver(observer interface{}, conf *config.ObserverConfig) error {
-	log.WithFields(log.Fields{
-		"config": *conf,
-	}).Debug("Configuring observer")
-
-	finalConfig := utils.CloneInterface(ConfigTemplates[conf.Type])
-
-	if err := config.FillInConfigTemplate("ObserverConfig", finalConfig, conf); err != nil {
-		return err
-	}
-
-	if err := validation.ValidateCustomConfig(finalConfig); err != nil {
-		return fmt.Errorf("observer config is invalid: %w", err)
-	}
-
-	return config.CallConfigure(observer, finalConfig)
-}

internal/signalfx-agent/pkg/observers/diagnostics.go

@@ -1,61 +1,9 @@
 package utils
 
 import (
-	"fmt"
-	"sort"
-	"strings"
-
-	"github.com/olekukonko/tablewriter"
 	"github.com/signalfx/golib/v3/datapoint"
 )
 
-func sortedDimensionString(dims map[string]string) string {
-	var keys []string
-	for k := range dims {
-		keys = append(keys, k)
-	}
-	sort.Strings(keys)
-
-	tableString := &strings.Builder{}
-	table := tablewriter.NewWriter(tableString)
-
-	table.SetHeader(keys)
-	var vals []string
-	for _, k := range keys {
-		vals = append(vals, dims[k])
-	}
-	table.Append(vals)
-	table.SetAutoFormatHeaders(false)
-
-	table.Render()
-	return tableString.String()
-}
-
-func dpTypeToString(t datapoint.MetricType) string {
-	switch t {
-	case datapoint.Gauge:
-		return "gauge"
-	case datapoint.Count:
-		return "counter"
-	case datapoint.Counter:
-		return "cumulative counter"
-	default:
-		return fmt.Sprintf("unsupported type %d", t)
-	}
-}
-
-// DatapointToString pretty prints a datapoint in a consistent manner for
-// logging purposes.  The most important thing here is to sort the dimension
-// dict so it is consistent so that it is easier to visually scan a large list
-// of datapoints.
-func DatapointToString(dp *datapoint.Datapoint) string {
-	var tsStr string
-	if !dp.Timestamp.IsZero() {
-		tsStr = dp.Timestamp.String()
-	}
-	return fmt.Sprintf("%s: %s (%s) %s\n%s\n", dp.Metric, dp.Value, strings.ToUpper(dpTypeToString(dp.MetricType)), tsStr, sortedDimensionString(dp.Dimensions))
-}
-
 // BoolToInt returns 1 if b is true and 0 otherwise.  It is useful for
 // datapoints which track a binary value since we don't support boolean
 // datapoint directly.
@@ -92,15 +40,3 @@ func SetDatapointMeta(dp *datapoint.Datapoint, name interface{}, val interface{}
 	}
 	dp.Meta[name] = val
 }
-
-func CloneDatapoint(dp *datapoint.Datapoint) *datapoint.Datapoint {
-	return datapoint.NewWithMeta(dp.Metric, CloneStringMap(dp.Dimensions), CloneFullInterfaceMap(dp.Meta), dp.Value, dp.MetricType, dp.Timestamp)
-}
-
-func CloneDatapointSlice(dps []*datapoint.Datapoint) []*datapoint.Datapoint {
-	out := make([]*datapoint.Datapoint, len(dps))
-	for i := range dps {
-		out[i] = CloneDatapoint(dps[i])
-	}
-	return out
-}