Skip to content

Commit 8358246

Browse files
committed
patch tests
1 parent 74807fe commit 8358246

File tree

1 file changed

+10
-12
lines changed

1 file changed

+10
-12
lines changed

tests/general/discoverymode/host_observer_discovery_test.go

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -196,12 +196,11 @@ func TestHostObserver(t *testing.T) {
196196
"prometheus_simple": map[string]any{
197197
"config": map[string]any{
198198
"collection_interval": "1s",
199-
//TODO: Re-enable test coverage after https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/40722
200-
//"labels": map[string]any{
201-
// "label_one": "${env:LABEL_ONE_VALUE}",
202-
// "label_two": "${LABEL_TWO_VALUE}",
203-
// "label_three": "actual.label.three.value.from.cmdline.property",
204-
//},
199+
"labels": map[string]any{
200+
"label_one": "${env:LABEL_ONE_VALUE}",
201+
"label_two": "${LABEL_TWO_VALUE}",
202+
"label_three": "actual.label.three.value.from.cmdline.property",
203+
},
205204
},
206205
"resource_attributes": map[string]any{},
207206
"rule": `type == "hostport" and command contains "otelcol" and port == ${INTERNAL_PROMETHEUS_PORT}`,
@@ -275,12 +274,11 @@ func TestHostObserver(t *testing.T) {
275274
"prometheus_simple": map[string]any{
276275
"config": map[string]any{
277276
"collection_interval": "1s",
278-
//TODO: Re-enable test coverage after https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/40722
279-
//"labels": map[string]any{
280-
// "label_one": "actual.label.one.value.from.env.var",
281-
// "label_two": "actual.label.two.value.from.env.var",
282-
// "label_three": "actual.label.three.value.from.cmdline.property",
283-
//},
277+
"labels": map[string]any{
278+
"label_one": "actual.label.one.value.from.env.var",
279+
"label_two": "actual.label.two.value.from.env.var",
280+
"label_three": "actual.label.three.value.from.cmdline.property",
281+
},
284282
},
285283
"resource_attributes": map[string]any{},
286284
"rule": fmt.Sprintf(`type == "hostport" and command contains "otelcol" and port == %d`, promPort),

0 commit comments

Comments
 (0)