Skip to content

Commit 87cb0f5

Browse files
authored
Deprecate windowslegacy monitor (#5518)
* Deprecate windowslegacy monitor * Update CHANGELOG.md
1 parent 37e12cd commit 87cb0f5

File tree

3 files changed

+3
-0
lines changed

3 files changed

+3
-0
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
- (Splunk) Deprecate the heroku observer. Use the [resource detection observer with heroku detector](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/processor/resourcedetectionprocessor#heroku) instead. ([#5496](https://github.com/signalfx/splunk-otel-collector/pull/5496))
1212
- (Splunk) Deprecate mongodb atlas monitor. [Please use the mongodbatlasreceiver instead](https://docs.splunk.com/observability/en/gdi/opentelemetry/components/mongodb-atlas-receiver.html) ([#](https://github.com/signalfx/splunk-otel-collector/pull/))
1313
- (Splunk) Deprecate python-monitor monitor ([#5501](https://github.com/signalfx/splunk-otel-collector/pull/5501))
14+
- (Splunk) Deprecate windowslegacy monitor ([#5518](https://github.com/signalfx/splunk-otel-collector/pull/5518))
1415
- (Splunk) Deprecate statsd monitor. Use the [statsd receiver](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/receiver/statsdreceiver) instead. ([#5513](https://github.com/signalfx/splunk-otel-collector/pull/5513))
1516

1617
## v0.111.0

internal/signalfx-agent/pkg/monitors/windowslegacy/metadata.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
monitors:
22
- dimensions:
33
doc: |
4+
**This monitor is deprecated and will be removed in a future release. Use the windowsperfcounters receiver instead.**
45
(Windows Only) This monitor reports metrics for Windows system Performance Counters.
56
The metric names are intended to match what was originally reported by
67
the SignalFx [PerfCounterReporter](https://github.com/signalfx/PerfCounterReporter)

internal/signalfx-agent/pkg/monitors/windowslegacy/windowslegacy_windows.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ var logger = logrus.WithField("monitorType", monitorType)
2020
// Configure the monitor and kick off metric syncing
2121
func (m *Monitor) Configure(conf *Config) error {
2222
m.logger = logger.WithField("monitorID", conf.MonitorID)
23+
m.logger.Warn("[NOTICE] The windowslegacy monitor is deprecated and will be removed in a future release. Use the windowsperfcounters receiver instead.")
2324
perfcounterConf := &winperfcounters.Config{
2425
CountersRefreshInterval: conf.CountersRefreshInterval,
2526
PrintValid: conf.PrintValid,

0 commit comments

Comments
 (0)