[ansible] Fix incorrect environmental variable naming (#6303)

* [chore][ansible] Update tests to confirm variables are set

* update version tag, fix naming difference

* fix test to check for right variable

* Update deployments/ansible/galaxy.yml

Author: crobert-1

deployments/ansible/molecule/custom_vars/verify.yml

@@ -22,48 +22,62 @@
         dest: /etc/otel/collector/splunk-otel-collector.conf
         state: present
       check_mode: yes
+      register: config
+      failed_when: config is changed
 
     - name: Assert SPLUNK_INGEST_URL env var is set
       ansible.builtin.lineinfile:
         line: SPLUNK_INGEST_URL=https://fake-splunk-ingest.com
         dest: /etc/otel/collector/splunk-otel-collector.conf
         state: present
       check_mode: yes
+      register: config
+      failed_when: config is changed
 
     - name: Assert SPLUNK_API_URL env var is set
       ansible.builtin.lineinfile:
         line: SPLUNK_API_URL=https://fake-splunk-api.com
         dest: /etc/otel/collector/splunk-otel-collector.conf
         state: present
       check_mode: yes
+      register: config
+      failed_when: config is changed
 
     - name: Assert SPLUNK_HEC_URL env var is set
       ansible.builtin.lineinfile:
         line: SPLUNK_HEC_URL=https://fake-splunk-ingest.com/v1/log
         dest: /etc/otel/collector/splunk-otel-collector.conf
         state: present
       check_mode: yes
+      register: config
+      failed_when: config is changed
 
     - name: Assert OTELCOL_OPTIONS env var is set per splunk_otel_collector_command_line_args
       ansible.builtin.lineinfile:
         line: OTELCOL_OPTIONS=--discovery
         dest: /etc/otel/collector/splunk-otel-collector.conf
         state: present
       check_mode: yes
+      register: config
+      failed_when: config is changed
 
     - name: Assert MY_CUSTOM_VAR1 env var is set
       ansible.builtin.lineinfile:
         line: MY_CUSTOM_VAR1=value1
         dest: /etc/otel/collector/splunk-otel-collector.conf
         state: present
       check_mode: yes
+      register: config
+      failed_when: config is changed
 
     - name: Assert MY_CUSTOM_VAR2 env var is set
       ansible.builtin.lineinfile:
         line: MY_CUSTOM_VAR2=value2
         dest: /etc/otel/collector/splunk-otel-collector.conf
         state: present
       check_mode: yes
+      register: config
+      failed_when: config is changed
 
     - name: Populate package facts
       ansible.builtin.package_facts:
@@ -78,34 +92,44 @@
         dest: /etc/systemd/system/splunk-otel-collector.service.d/service-owner.conf
         state: present
       check_mode: yes
+      register: config
+      failed_when: config is changed
 
     - name: Assert custom service group is set
       ansible.builtin.lineinfile:
         line: Group=custom-group
         dest: /etc/systemd/system/splunk-otel-collector.service.d/service-owner.conf
         state: present
       check_mode: yes
+      register: config
+      failed_when: config is changed
 
     - name: Assert SPLUNK_MEMORY_TOTAL_MIB env var is set
       ansible.builtin.lineinfile:
         line: SPLUNK_MEMORY_TOTAL_MIB=256
         dest: /etc/otel/collector/splunk-otel-collector.conf
         state: present
       check_mode: yes
+      register: config
+      failed_when: config is changed
 
     - name: Assert SPLUNK_LISTEN_INTERFACE env var is set
       ansible.builtin.lineinfile:
         line: SPLUNK_LISTEN_INTERFACE=1.2.3.4
         dest: /etc/otel/collector/splunk-otel-collector.conf
         state: present
       check_mode: yes
+      register: config
+      failed_when: config is changed
 
     - name: Assert GOMEMLIMIT env var is set
       ansible.builtin.lineinfile:
         line: GOMEMLIMIT=230
         dest: /etc/otel/collector/splunk-otel-collector.conf
         state: present
       check_mode: yes
+      register: config
+      failed_when: config is changed
 
     - name: Check custom_fluentd.conf
       stat:
@@ -124,6 +148,8 @@
         state: present
       check_mode: yes
       when: fluentd_supported
+      register: config
+      failed_when: config is changed
 
     - name: Send a test log message
       ansible.builtin.uri:

deployments/ansible/molecule/default/verify.yml

@@ -21,31 +21,41 @@
         dest: /etc/otel/collector/splunk-otel-collector.conf
         state: present
       check_mode: yes
+      register: config
+      failed_when: config is changed
 
     - name: Assert SPLUNK_REALM env var is set
       ansible.builtin.lineinfile:
         line: SPLUNK_REALM=fake-realm
         dest: /etc/otel/collector/splunk-otel-collector.conf
         state: present
       check_mode: yes
+      register: config
+      failed_when: config is changed
 
     - name: Assert SPLUNK_INGEST_URL env var is set
       ansible.builtin.lineinfile:
         line: SPLUNK_INGEST_URL=https://ingest.fake-realm.signalfx.com
         dest: /etc/otel/collector/splunk-otel-collector.conf
         state: present
       check_mode: yes
+      register: config
+      failed_when: config is changed
 
     - name: Assert SPLUNK_API_URL env var is set
       ansible.builtin.lineinfile:
-        line: SPLUNK_INGEST_URL=https://api.fake-realm.signalfx.com
+        line: SPLUNK_API_URL=https://api.fake-realm.signalfx.com
         dest: /etc/otel/collector/splunk-otel-collector.conf
         state: present
       check_mode: yes
+      register: config
+      failed_when: config is changed
 
     - name: Assert SPLUNK_HEC_URL env var is set
       ansible.builtin.lineinfile:
         line: SPLUNK_HEC_URL=https://ingest.fake-realm.signalfx.com/v1/log
         dest: /etc/otel/collector/splunk-otel-collector.conf
         state: present
       check_mode: yes
+      register: config
+      failed_when: config is changed

deployments/ansible/roles/collector/templates/splunk-otel-collector.conf.j2

@@ -1,4 +1,4 @@
-OTELCOL_CONFIG={{ splunk_otel_collector_command_line_args }}
+OTELCOL_OPTIONS={{ splunk_otel_collector_command_line_args }}
 SPLUNK_CONFIG={{ splunk_otel_collector_config }}
 SPLUNK_ACCESS_TOKEN={{ splunk_access_token }}
 SPLUNK_REALM={{ splunk_realm }}