Add cassanda jmx to discovery #5112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
timeout issue, gotta figure out how to best wait for |
hughesjj
force-pushed
the
add_cassanda_jmx
branch
3 times, most recently
from
e7ce63e to
ddd0068
Compare
jeffreyc-splunk
suggested changes
Jul 22, 2024
hughesjj
force-pushed
the
add_cassanda_jmx
branch
3 times, most recently
from
71294b2 to
5f383f2
Compare
|
@hughesjj LGTM but may be we should wait for jeff's comment. |
samiura
approved these changes
Jul 24, 2024
|
needs to rebase as well |
…get to running the integ test
hughesjj
force-pushed
the
add_cassanda_jmx
branch
from
5f383f2 to
7a5e164
Compare
jeffreyc-splunk
approved these changes
Jul 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to test locally, first start a cassandra cluster with
docker compose --file docker/docker-compose.yml --profile cassandra upThen,
make bundle.d && make otelcol && make integration-test-jmx-discovery