[chore][ansible] Run Windows tests against current build #6309
Conversation
There was a problem hiding this comment.
agent-bundle-windows, msi-custom-actions, and msi-build are all directly copied from https://github.com/signalfx/splunk-otel-collector/blob/main/.github/workflows/win-package-test.yml
| @@ -257,6 +359,11 @@ jobs: | |||
| - name: Check out the codebase. | |||
| uses: actions/checkout@v4 | |||
|
|
|||
| - uses: actions/download-artifact@v4 | |||
| with: | |||
| name: msi-build | |||
There was a problem hiding this comment.
For simplicity in Ansible logic, use a single MSI with a preset name, rather than having to pass around variables and parse versions.
There was a problem hiding this comment.
This file is simply tasks moved from otel_win_install.yml for cleaning up the organization of functionality.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6309 +/- ##
==========================================
+ Coverage 43.73% 43.74% +0.01%
==========================================
Files 390 390
Lines 26995 26995
==========================================
+ Hits 11806 11810 +4
+ Misses 14340 14338 -2
+ Partials 849 847 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @@ -45,23 +45,6 @@ | |||
| assert: | |||
| that: not service_status.changed | |||
|
|
|||
| - name: Download splunk-otel-collector 0.126.0 MSI | |||
There was a problem hiding this comment.
Removed version check for the same reason as the linux change. We can revisit if anyone has a strong preference here.
| @@ -1,42 +1,18 @@ | |||
| --- | |||
|
|
|||
| - name: Get splunk-otel-collector latest version | |||
There was a problem hiding this comment.
Deleted lines from this file are simply being moved to the win_download_remote_msi,yml task in the same directory.
Description:
Essentially the same effort as #6284. The functionality of installing the MSI has been split into two files, one for fetching the MSI from the public releases URL, one for fetching the MSI from the locally built artifacts. The split logic is to copy the MSI to ansible's target machine at a set path. Functionality can proceed the same way for both installations from there.