-
Notifications
You must be signed in to change notification settings - Fork 167
Backport fix to ensure the bug does not affect splunk-otel-collector v0.127.0 #6314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…s://github.com/open-telemetry/opentelemetry-collector/releases/tag/v0.128.0 to ensure the bug does not affect splunk-otel-collector v0.127.0.
1cabbe1
to
b32618d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6314 +/- ##
==========================================
- Coverage 43.73% 43.72% -0.02%
==========================================
Files 390 390
Lines 26995 26995
==========================================
- Hits 11806 11803 -3
- Misses 14340 14341 +1
- Partials 849 851 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Two Integration Test check failures exist and are expected due to test coverage failures, they are unrelated to this PR. |
-> go.opentelemetry.io/collector/confmap v1.34.0 go.opentelemetry.io/collector/confmap/provider/envprovider v1.34.0 go.opentelemetry.io/collector/confmap/provider/fileprovider v1.34.0 go.opentelemetry.io/collector/confmap/provider/yamlprovider v1.34.0 go.opentelemetry.io/collector/confmap/xconfmap v0.128.0
b88f1c2
to
e864913
Compare
224ed48
to
02f04c8
Compare
475627c
to
bfd95b9
Compare
Tests are failing because of open-telemetry/opentelemetry-collector#12981, tests need to be updated to properly account for upstream change. |
2854fe3
to
d847f73
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's no longer valid to pass an empty config and expect a non-nil response from confmap. The test case should be updated to contain valid "default" information for the component that is not empty. 👍
9b42bda
to
93faf22
Compare
93faf22
to
a1e78a2
Compare
The two failing check for the integration tests will be fixed in a separate PR. |
Backported open-telemetry/opentelemetry-collector#13117 fix from https://github.com/open-telemetry/opentelemetry-collector/releases/tag/v0.128.0 to ensure the bug does not affect splunk-otel-collector v0.127.0.