-
Notifications
You must be signed in to change notification settings - Fork 167
[chore][CICD] Reuse more GitHub workflow jobs #6329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
a131b0e
to
11bf6b6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6329 +/- ##
==========================================
+ Coverage 36.83% 44.93% +8.09%
==========================================
Files 381 390 +9
Lines 26732 26995 +263
==========================================
+ Hits 9848 12130 +2282
+ Misses 15908 14000 -1908
+ Partials 976 865 -111 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2ccfc1f
to
2b64aa3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR moves setup-environment
from a reusable workflow to a composite action, as the steps should be run in the same job as the dependent functionality.
09d5fd8
to
2d39066
Compare
- name: Check out the codebase. | ||
uses: actions/checkout@v4 | ||
with: | ||
fetch-depth: 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use this in other places also?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you referring to the workflow as a whole, msi-build
, or something else? From what I can tell I've updated all references to use this workflow as a whole (just updating the Ansible workflow now), but maybe I'm misunderstanding your question
2d39066
to
4bfa7c2
Compare
Description:
Builds on #6306.
Notes:
darwin-test.yml
as functionality is now covered bybuild-and-test.yml
. If we want to keepdarwin-test.yml
for some reason, let me know.