Skip to content

[chore][CICD] Reuse more GitHub workflow jobs #6329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

crobert-1
Copy link
Contributor

Description:

Builds on #6306.

Notes:

  1. Some of the Windows build and packaging workflows are only being used in one place in this PR, but it will be utilized by [chore][ansible] Run Windows tests against current build #6309
  2. All input arguments to reusable workflows have been moved to be all capitalized.
  3. Deleted darwin-test.yml as functionality is now covered by build-and-test.yml. If we want to keep darwin-test.yml for some reason, let me know.

@crobert-1 crobert-1 force-pushed the reuse_more_workflows branch from a131b0e to 11bf6b6 Compare June 16, 2025 20:46
@crobert-1 crobert-1 changed the title Reuse more workflows [chore][CICD] Reuse more GitHub workflow jobs Jun 16, 2025
Copy link

codecov bot commented Jun 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.93%. Comparing base (ae23889) to head (6a49807).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6329      +/-   ##
==========================================
+ Coverage   36.83%   44.93%   +8.09%     
==========================================
  Files         381      390       +9     
  Lines       26732    26995     +263     
==========================================
+ Hits         9848    12130    +2282     
+ Misses      15908    14000    -1908     
+ Partials      976      865     -111     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@crobert-1 crobert-1 force-pushed the reuse_more_workflows branch from 2ccfc1f to 2b64aa3 Compare June 16, 2025 20:59
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR moves setup-environment from a reusable workflow to a composite action, as the steps should be run in the same job as the dependent functionality.

@crobert-1 crobert-1 force-pushed the reuse_more_workflows branch from 09d5fd8 to 2d39066 Compare June 17, 2025 17:15
@crobert-1 crobert-1 marked this pull request as ready for review June 18, 2025 15:02
@crobert-1 crobert-1 requested review from a team as code owners June 18, 2025 15:02
- name: Check out the codebase.
uses: actions/checkout@v4
with:
fetch-depth: 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use this in other places also?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you referring to the workflow as a whole, msi-build, or something else? From what I can tell I've updated all references to use this workflow as a whole (just updating the Ansible workflow now), but maybe I'm misunderstanding your question

@crobert-1 crobert-1 force-pushed the reuse_more_workflows branch from 2d39066 to 4bfa7c2 Compare June 18, 2025 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants