Add function for determining key_details
#1456
Merged
+209
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ramon Petgrave <[email protected]>
Signed-off-by: Ramon Petgrave <[email protected]>
Signed-off-by: Ramon Petgrave <[email protected]>
Signed-off-by: Ramon Petgrave <[email protected]>
Signed-off-by: Ramon Petgrave <[email protected]>
jku
reviewed
Jun 23, 2025
There was a problem hiding this comment.
The actual method looks pretty good (although maybe it could live in sigstore/_utils.py like other random methods like this).
Addresses #1439
This is not true since this only modifies the signing code (I assume the plan was to extend this to support verification as well later on) .
- I think we can re-use the code for signing and verification like it looks like you planned but it's worth noting that
- The signing code does not strictly speaking need this support (since there keytype is hard coded anyway and there's no plans to make that configurable at the moment)
- this re-use saves 7 lines of code
- the requirements for signing & verification might end up different: maybe we want to support the "not recommended" algorithms for verification but not for signing
- let's at least wait until #1432 so we can plug this into the verification code where it will be actually useful
Signed-off-by: Ramon Petgrave <[email protected]>
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Client support for Rekor V2: sigstore-python #289
Partially addresses #1439
Inspired by https://github.com/sigstore/sigstore-python/pull/1432/files#diff-0287921ae266ddac61ace4f5d2ee5fa8e74495f6e3a7c231d3715a31679690b1R622-R651
Adds a function for determining the
key_detailsof a certificate.Note that this does not add direct support for signing with the various key types, but in the future will aid with sending requests to Rekor and verifying Entry body contents.
Release Note
key_detailsof a certificate`.Documentation