Skip to content

Commit 8cc118d

Browse files
johnstiles-googleSkia Commit-Bot
authored andcommitted
Fix mislabeled argument comments.
Once the existing cases are fixed, we can enable bugprone-argument- comment to allow clang-tidy to verify these for us automatically going forward. (http://review.skia.org/306848) Change-Id: I5c21b28bcbdebb6b74c2924cc5f19c48446ecb42 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/306847 Reviewed-by: Florin Malita <[email protected]> Commit-Queue: John Stiles <[email protected]>
1 parent de53ba5 commit 8cc118d

File tree

4 files changed

+7
-7
lines changed

4 files changed

+7
-7
lines changed

gm/vertices.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -524,8 +524,8 @@ static sk_sp<SkVertices> make_cone(Attr::Usage u, const char* markerName) {
524524
// +1 for the center, +1 to repeat the first perimeter point (so we draw a complete circle)
525525
constexpr int kNumVerts = kPerimeterVerts + 2;
526526

527-
SkVertices::Builder builder(SkVertices::kTriangleFan_VertexMode, kNumVerts, /*index_count=*/ 0,
528-
&attr, /*attr_count=*/ 1);
527+
SkVertices::Builder builder(SkVertices::kTriangleFan_VertexMode, kNumVerts, /*indexCount=*/0,
528+
&attr, /*attrCount=*/1);
529529

530530
SkPoint* pos = builder.positions();
531531
SkPoint3* vec = static_cast<SkPoint3*>(builder.customData());

src/core/SkColorFilter_Matrix.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -132,15 +132,15 @@ GrFPResult SkColorFilter_Matrix::asFragmentProcessor(std::unique_ptr<GrFragmentP
132132
switch (fDomain) {
133133
case Domain::kRGBA:
134134
fp = GrColorMatrixFragmentProcessor::Make(std::move(fp), fMatrix,
135-
/* premulInput = */ true,
135+
/* unpremulInput = */ true,
136136
/* clampRGBOutput = */ true,
137137
/* premulOutput = */ true);
138138
break;
139139

140140
case Domain::kHSLA:
141141
fp = GrRGBToHSLFilterEffect::Make(std::move(fp));
142142
fp = GrColorMatrixFragmentProcessor::Make(std::move(fp), fMatrix,
143-
/* premulInput = */ false,
143+
/* unpremulInput = */ false,
144144
/* clampRGBOutput = */ false,
145145
/* premulOutput = */ false);
146146
fp = GrHSLToRGBFilterEffect::Make(std::move(fp));

src/core/SkDevice.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
#include "src/utils/SkPatchUtils.h"
3434

3535
SkBaseDevice::SkBaseDevice(const SkImageInfo& info, const SkSurfaceProps& surfaceProps)
36-
: SkMatrixProvider(/* fLocalToDevice = */ SkMatrix::I())
36+
: SkMatrixProvider(/* localToDevice = */ SkMatrix::I())
3737
, fInfo(info)
3838
, fSurfaceProps(surfaceProps) {
3939
fDeviceToGlobal.reset();

tools/fm/fm.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -206,8 +206,8 @@ static void init(Source* source, sk_sp<skottie::Animation> animation) {
206206
for (int x : order) {
207207
SkRect dst = {x*dim, y*dim, (x+1)*dim, (y+1)*dim};
208208

209-
SkAutoCanvasRestore _(canvas, true/*save now*/);
210-
canvas->clipRect(dst, /*aa=*/true);
209+
SkAutoCanvasRestore _(canvas, /*doSave=*/true);
210+
canvas->clipRect(dst, /*doAntiAlias=*/true);
211211
canvas->concat(SkMatrix::MakeRectToRect(SkRect::MakeSize(animation->size()),
212212
dst,
213213
SkMatrix::kCenter_ScaleToFit));

0 commit comments

Comments
 (0)