Skip to content

Commit 010a93b

Browse files
committed
Fix get_answers_in_submission to account for nonexistent submission
1 parent 3f0908c commit 010a93b

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

lib/cadet/assessments/assessments.ex

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1380,12 +1380,11 @@ defmodule Cadet.Assessments do
13801380
end
13811381
end)
13821382

1383-
assessment_id = Submission |> where(id: ^id) |> select([s], s.assessment_id) |> Repo.one()
1384-
assessment = Assessment |> where(id: ^assessment_id) |> Repo.one()
1385-
13861383
if answers == [] do
13871384
{:error, {:bad_request, "Submission is not found."}}
13881385
else
1386+
assessment_id = Submission |> where(id: ^id) |> select([s], s.assessment_id) |> Repo.one()
1387+
assessment = Assessment |> where(id: ^assessment_id) |> Repo.one()
13891388
{:ok, {answers, assessment}}
13901389
end
13911390
end

0 commit comments

Comments
 (0)