fixed minor typo and renaming

Author: DesSnowy

lib/cadet_web/admin_controllers/admin_assessments_controller.ex

@@ -135,7 +135,7 @@ defmodule CadetWeb.AdminAssessmentsController do
     end
   end
 
-  def get_score_learderboard(conn, %{"assessmentid" => assessment_id, "course_id" => course_id}) do
+  def get_score_leaderboard(conn, %{"assessmentid" => assessment_id, "course_id" => course_id}) do
     voting_questions =
       Question
       |> where(type: :voting)
@@ -154,7 +154,7 @@ defmodule CadetWeb.AdminAssessmentsController do
     render(conn, "leaderboard.json", leaderboard: result)
   end
 
-  def get_popular_learderboard(conn, %{"assessmentid" => assessment_id, "course_id" => course_id}) do
+  def get_popular_leaderboard(conn, %{"assessmentid" => assessment_id, "course_id" => course_id}) do
     voting_questions =
       Question
       |> where(type: :voting)
@@ -269,7 +269,7 @@ defmodule CadetWeb.AdminAssessmentsController do
     response(403, "Forbidden")
   end
 
-  swagger_path :get_popular_learderboard do
+  swagger_path :get_popular_leaderboard do
     get("/courses/{course_id}/admin/assessments/:assessmentid/popularVoteLeaderboard")
 
     summary("get the top 10 contest entries based on popularity")
@@ -285,7 +285,7 @@ defmodule CadetWeb.AdminAssessmentsController do
     response(403, "Forbidden")
   end
 
-  swagger_path :get_score_learderboard do
+  swagger_path :get_score_leaderboard do
     get("/courses/{course_id}/admin/assessments/:assessmentid/scoreLeaderboard")
 
     summary("get the top 10 contest entries based on score")

lib/cadet_web/admin_views/admin_assessments_view.ex

@@ -67,14 +67,12 @@ defmodule CadetWeb.AdminAssessmentsView do
   end
 
   def render("leaderboard.json", %{leaderboard: leaderboard}) do
-    render_many(leaderboard, CadetWeb.AdminAssessmentsView, "contestEntries.json",
-      as: :contestEntries
-    )
+    render_many(leaderboard, CadetWeb.AdminAssessmentsView, "contestEntry.json", as: :contestEntry)
   end
 
-  def render("contestEntries.json", %{contestEntries: contestEntries}) do
+  def render("contestEntry.json", %{contestEntry: contestEntry}) do
     transform_map_for_view(
-      contestEntries,
+      contestEntry,
       %{
         student_name: :student_name,
         answer: & &1.answer["code"],

lib/cadet_web/router.ex

@@ -121,13 +121,13 @@ defmodule CadetWeb.Router do
     get(
       "/assessments/:assessmentid/popularVoteLeaderboard",
       AdminAssessmentsController,
-      :get_popular_learderboard
+      :get_popular_leaderboard
     )
 
     get(
       "/assessments/:assessmentid/scoreLeaderboard",
       AdminAssessmentsController,
-      :get_score_learderboard
+      :get_score_leaderboard
     )
 
     get("/grading", AdminGradingController, :index)

lib/cadet_web/views/assessments_view.ex

@@ -68,14 +68,12 @@ defmodule CadetWeb.AssessmentsView do
   end
 
   def render("leaderboard.json", %{leaderboard: leaderboard}) do
-    render_many(leaderboard, CadetWeb.AdminAssessmentsView, "contestEntries.json",
-      as: :contestEntries
-    )
+    render_many(leaderboard, CadetWeb.AdminAssessmentsView, "contestEntry.json", as: :contestEntry)
   end
 
-  def render("contestEntries.json", %{contestEntries: contestEntries}) do
+  def render("contestEntry.json", %{contestEntry: contestEntry}) do
     transform_map_for_view(
-      contestEntries,
+      contestEntry,
       %{
         student_name: :student_name,
         answer: & &1.answer["code"],