Skip to content

Bump js-slang and update infinite loop detector #1870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 26, 2021
Merged

Bump js-slang and update infinite loop detector #1870

merged 2 commits into from
Jul 26, 2021

Conversation

JoeyChenSmart
Copy link
Contributor

Description

Bump js-slang to 0.5.12.

The new version of js-slang implements an overhauled infinite loop detector which breaks certain features depending on the old implementation (namely the reporting infinite loop to sentry feature).

The new reporting feature can be turned on/off depending on whether the user has given approval or not.
This approval flag (state.session.experimentApproval in the state) is set to 'false' as default.
A future change should check for the user's given approval status and set this flag accordingly.

Also, as discussed in the meeting, we will only show the 'enhanced' infinite loop errors 50% of the time.

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How to test

Run an infinite loop into the playground. The new error should show up 50% of the time. Refresh the page to 'reroll' for different results.

image

Checklist

  • I have tested this code

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1066740485

  • 15 of 15 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 29.706%

Totals Coverage Status
Change from base Build 1066010755: -0.3%
Covered Lines: 3164
Relevant Lines: 9780

💛 - Coveralls

Copy link
Member

@martin-henz martin-henz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@martin-henz martin-henz merged commit 6e6e417 into source-academy:master Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants