Bump js-slang and update infinite loop detector #1870
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bump js-slang to 0.5.12.
The new version of js-slang implements an overhauled infinite loop detector which breaks certain features depending on the old implementation (namely the reporting infinite loop to sentry feature).
The new reporting feature can be turned on/off depending on whether the user has given approval or not.
This approval flag (state.session.experimentApproval in the state) is set to 'false' as default.
A future change should check for the user's given approval status and set this flag accordingly.
Also, as discussed in the meeting, we will only show the 'enhanced' infinite loop errors 50% of the time.
Type of change
How to test
Run an infinite loop into the playground. The new error should show up 50% of the time. Refresh the page to 'reroll' for different results.
Checklist