Skip to content

Fix output not appearing in snippets which are not evaluated #1877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 28, 2021

Conversation

samuelfangjw
Copy link
Contributor

Description

Fixes #1876

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

For snippets which are not evaluated, output should be visible (if present). For example, the chapter 4.4.1, lives_near(list, "Reasoner"... should be visible, as seen in the screenshot below.

Screenshot 2021-07-28 at 12 58 00 PM

Checklist

  • I have tested this code
  • I have updated the documentation

Copy link
Member

@martin-henz martin-henz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should always show the expected output, regardless whether the program is runnable or not.

@coveralls
Copy link

coveralls commented Jul 28, 2021

Pull Request Test Coverage Report for Build 1073781230

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 29.719%

Totals Coverage Status
Change from base Build 1067179111: 0.01%
Covered Lines: 3164
Relevant Lines: 9780

💛 - Coveralls

@samuelfangjw
Copy link
Contributor Author

samuelfangjw commented Jul 28, 2021

I think we should always show the expected output, regardless whether the program is runnable or not.

This is already the case for all runnable program snippets that have <JAVASCRIPT_OUTPUT>, apologies if my initial comment was misleading.
Screenshot 2021-07-28 at 1 45 33 PM

I've taken this chance to also italicise <JAVASCRIPT_OUTPUT>, as per the specs, as well tweak the styles of code snippets very slightly so that snippets can be displayed without having to scroll horizontally on larger screens.

@samuelfangjw samuelfangjw requested a review from martin-henz July 28, 2021 05:50
Copy link
Member

@martin-henz martin-henz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good

@martin-henz martin-henz merged commit 7354ddf into source-academy:master Jul 28, 2021
@samuelfangjw samuelfangjw deleted the output-snippets branch August 2, 2021 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing code/text in section 4.4.1
3 participants