React18 #2504
Merged
React18 #2504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 5342448651
💛 - Coveralls |
… v18 and fix tests
RichDom2185
pushed a commit
to NUS-CS1101S/cadet-frontend
that referenced
this pull request
Jul 15, 2023
* Upgrade React and corresponding types to latest version * Deprecate usage of React.SFC * Fix miscellaneous type errors * Upgrade react-konva to fix type errors with react18 * Fix typings for react-sortable-hoc * Shift root render to new API * Fix @types/react versioning * Fix navigation bar typing * Fix useEffect return type * Upgrade @testing-library/react and react-test-renderer to match react v18 and fix tests * Workaround deprecated ReactDOM.render used by Blueprintjs v4 * Update notification import lines
RichDom2185
pushed a commit
to NUS-CS1101S/cadet-frontend
that referenced
this pull request
Aug 15, 2023
* Upgrade React and corresponding types to latest version * Deprecate usage of React.SFC * Fix miscellaneous type errors * Upgrade react-konva to fix type errors with react18 * Fix typings for react-sortable-hoc * Shift root render to new API * Fix @types/react versioning * Fix navigation bar typing * Fix useEffect return type * Upgrade @testing-library/react and react-test-renderer to match react v18 and fix tests * Workaround deprecated ReactDOM.render used by Blueprintjs v4 * Update notification import lines
7 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade to react v18.
Blocked by the follow 2 changes:
Deprecate all usages of
ReactDOM.renderToast.create()method inNotificationHelper.ts(see Migrate BlueprintJS OverlayToaster Component #2529)DialogHelper.tsx(which was originally referenced from BlueprintJS toast implementation)Test suite still uses
ReactDOM.render(see Migrate out of enzyme testing library for React18 upgrade #2520)Type of change
How to test
Checklist