Refactor grading dashboard and reduce API overhead #2643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves descriptiveness.
Improves readability.
* Rename `showGraded` to `showAllSubmissions` for clarity * Pass a new copy of submissions array to table (immutability) * Move conditional logic into array filter
Pull Request Test Coverage Report for Build 5978391278
💛 - Coveralls |
RichDom2185
added a commit
to NUS-CS1101S/cadet-frontend
that referenced
this pull request
Aug 25, 2023
* Use useSession hook instead of useTypedSelector * Show all submissions only for admins by default * Add FIXME * Refactor CSV exporter to separate file * Rename `data` to `submissions` Improves descriptiveness. * Remove unnecessary GradingDashboard abstraction * Simplify redundant code * Move ungraded submission filter to GradingUtils Improves readability. * Refactor filtering logic * Rename `showGraded` to `showAllSubmissions` for clarity * Pass a new copy of submissions array to table (immutability) * Move conditional logic into array filter * Create SimpleDropdown custom component * Allow staff to view all groups via dropdown
7 tasks
RichDom2185
added a commit
to NUS-CS1101S/cadet-frontend
that referenced
this pull request
Aug 25, 2023
* Use useSession hook instead of useTypedSelector * Show all submissions only for admins by default * Add FIXME * Refactor CSV exporter to separate file * Rename `data` to `submissions` Improves descriptiveness. * Remove unnecessary GradingDashboard abstraction * Simplify redundant code * Move ungraded submission filter to GradingUtils Improves readability. * Refactor filtering logic * Rename `showGraded` to `showAllSubmissions` for clarity * Pass a new copy of submissions array to table (immutability) * Move conditional logic into array filter * Create SimpleDropdown custom component * Allow staff to view all groups via dropdown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mainly refactored code, but also added new custom components to support minimal dropdowns, and also restored the old behaviour of allowing staff to toggle between viewing only submissions from their own group (now the default) or all groups. This was previously removed in #2437.
With over 100 groups, this would result in a >100x performance improvement.
New UI:
Type of change
Checklist