From c929ae742bc5e91e1de4cbd822f8ec29d3622cd7 Mon Sep 17 00:00:00 2001 From: positivelyjon Date: Tue, 13 Feb 2024 12:21:06 +0800 Subject: [PATCH 1/3] Rename contest leaderboard to score leaderboard --- src/commons/assessment/AssessmentTypes.ts | 2 +- src/commons/assessmentWorkspace/AssessmentWorkspace.tsx | 6 +++--- src/commons/mocks/AssessmentMocks.ts | 2 +- src/commons/sideContent/SideContentContestLeaderboard.tsx | 2 +- src/commons/sideContent/SideContentTypes.ts | 2 +- 5 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/commons/assessment/AssessmentTypes.ts b/src/commons/assessment/AssessmentTypes.ts index 0169f52ad0..6b1144e931 100644 --- a/src/commons/assessment/AssessmentTypes.ts +++ b/src/commons/assessment/AssessmentTypes.ts @@ -121,7 +121,7 @@ export interface IContestVotingQuestion extends BaseQuestion { prepend: string; postpend: string; contestEntries: ContestEntry[]; - contestLeaderboard: ContestEntry[]; + scoreLeaderboard: ContestEntry[]; type: 'voting'; } diff --git a/src/commons/assessmentWorkspace/AssessmentWorkspace.tsx b/src/commons/assessmentWorkspace/AssessmentWorkspace.tsx index 6aa3fd43c9..7aec87268c 100644 --- a/src/commons/assessmentWorkspace/AssessmentWorkspace.tsx +++ b/src/commons/assessmentWorkspace/AssessmentWorkspace.tsx @@ -444,15 +444,15 @@ const AssessmentWorkspace: React.FC = props => { id: SideContentType.contestVoting }, { - label: 'Contest Leaderboard', + label: 'Score Leaderboard', iconName: IconNames.CROWN, body: ( ), - id: SideContentType.contestLeaderboard + id: SideContentType.scoreLeaderboard } ); } else { diff --git a/src/commons/mocks/AssessmentMocks.ts b/src/commons/mocks/AssessmentMocks.ts index c79600441c..5f7deaca51 100644 --- a/src/commons/mocks/AssessmentMocks.ts +++ b/src/commons/mocks/AssessmentMocks.ts @@ -862,7 +862,7 @@ const mockContestEntryQuestion: Array = [ answer: { code: 'function voting_test() { return true; }' } } ], - contestLeaderboard: [ + scoreLeaderboard: [ { submission_id: 1, student_name: 'student_1', diff --git a/src/commons/sideContent/SideContentContestLeaderboard.tsx b/src/commons/sideContent/SideContentContestLeaderboard.tsx index 85bc9d7311..3f123cfdce 100644 --- a/src/commons/sideContent/SideContentContestLeaderboard.tsx +++ b/src/commons/sideContent/SideContentContestLeaderboard.tsx @@ -79,7 +79,7 @@ const SideContentContestLeaderboard: React.FunctionComponent< minimal={true} onClick={() => setShowLeaderboard(!showLeaderboard)} > - Contest Leaderboard + Score Leaderboard diff --git a/src/commons/sideContent/SideContentTypes.ts b/src/commons/sideContent/SideContentTypes.ts index c962f3cb98..16911a57b0 100644 --- a/src/commons/sideContent/SideContentTypes.ts +++ b/src/commons/sideContent/SideContentTypes.ts @@ -8,7 +8,7 @@ export enum SideContentType { autograder = 'autograder', briefing = 'briefing', contestVoting = 'contest_voting', - contestLeaderboard = 'contest_leaderboard', + scoreLeaderboard = 'score_leaderboard', dataVisualizer = 'data_visualizer', editorGrading = 'editor_grading', editorAutograder = 'editor_autograder', From 12f3e4a94e6c8bf88fc38805c6d472f34089efb7 Mon Sep 17 00:00:00 2001 From: positivelyjon Date: Tue, 13 Feb 2024 12:44:52 +0800 Subject: [PATCH 2/3] Modify tests --- .../__snapshots__/AssessmentWorkspace.tsx.snap | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/commons/assessmentWorkspace/__tests__/__snapshots__/AssessmentWorkspace.tsx.snap b/src/commons/assessmentWorkspace/__tests__/__snapshots__/AssessmentWorkspace.tsx.snap index 34f8d721fa..c936aa38ae 100644 --- a/src/commons/assessmentWorkspace/__tests__/__snapshots__/AssessmentWorkspace.tsx.snap +++ b/src/commons/assessmentWorkspace/__tests__/__snapshots__/AssessmentWorkspace.tsx.snap @@ -470,13 +470,13 @@ exports[`AssessmentWorkspace AssessmentWorkspace page with ContestVoting questio