Skip to content

Refactor game fullscreen code #2953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 1, 2024
Merged

Conversation

Johnwz123
Copy link
Contributor

Description

Follow-up on #2855

Refactor Game fullscreen button to match Playground side content fullscreen button

  • Replace Icon with Button
  • Replace htmlTitle with Tooltip
  • Move function declarations out of useEffect body
  • Change to use class instead of id
  • Remove unnecessary styles

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

Checklist

  • I have tested this code
  • I have updated the documentation

@Johnwz123 Johnwz123 self-assigned this Apr 22, 2024
@coveralls
Copy link

coveralls commented Apr 22, 2024

Pull Request Test Coverage Report for Build 8912431498

Details

  • 0 of 13 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 33.067%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/pages/academy/game/Game.tsx 0 13 0.0%
Totals Coverage Status
Change from base Build 8912047561: 0.0%
Covered Lines: 5299
Relevant Lines: 14891

💛 - Coveralls

Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@RichDom2185 RichDom2185 enabled auto-merge (squash) May 1, 2024 17:10
@RichDom2185 RichDom2185 merged commit c0384ee into master May 1, 2024
@RichDom2185 RichDom2185 deleted the dev/refactor-game-fullscreen branch May 1, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants