Skip to content

Miscellaneous changes #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 46 commits into from
Feb 24, 2025
Merged

Miscellaneous changes #314

merged 46 commits into from
Feb 24, 2025

Conversation

RichDom2185
Copy link
Member

Description

Cleaned up stuff.

Devserver now works on my computer.

yarn install now works on my computer.

Please refer to commit titles for changelog.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Code quality improvements

@RichDom2185 RichDom2185 requested a review from sayomaki May 21, 2024 22:41
@RichDom2185 RichDom2185 self-assigned this May 21, 2024
@RichDom2185 RichDom2185 marked this pull request as draft May 22, 2024 10:05
package.json Outdated
@@ -135,7 +132,6 @@
]
},
"resolutions": {
"esbuild": "^0.18.20",
"**/gl": "^6.0.2"
"**/gl": "^8.0.2"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, @sayomaki this resolution seems to be breaking the CI again, which is weird, because locally, I can run the commands just fine.

This is different from frontend where I am faced with the same error locally.

@RichDom2185 RichDom2185 marked this pull request as ready for review May 22, 2024 10:29
@RichDom2185
Copy link
Member Author

Hope you don't mind if I add some minor changes alongside

All's good! If you are free, could you help with the review? Thanks!

@RichDom2185 RichDom2185 requested a review from martin-henz July 18, 2024 13:51
@RichDom2185
Copy link
Member Author

Hope you don't mind if I add some minor changes alongside

All's good! If you are free, could you help with the review? Thanks!

@leeyi45 bumping this

@RichDom2185 RichDom2185 requested a review from leeyi45 August 18, 2024 09:07
@RichDom2185 RichDom2185 merged commit 0aa06b3 into master Feb 24, 2025
3 checks passed
@RichDom2185 RichDom2185 deleted the misc-20240522 branch February 24, 2025 02:21
JustATin555 added a commit that referenced this pull request Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants