Deprecate events-emitter-es6 for node:events #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
RichDom2185
reviewed
Jul 17, 2025
package.json
Outdated
Comment on lines
57
to
56
| }, | ||
| "packageManager": "[email protected]+sha512.a6b2f7906b721bba3d67d4aff083df04dad64c399707841b7acf00f6b133b7ac24255f2652fa22ae3534329dc6180534e98d17432037ff6fd140556e2bb3137e" | ||
| } |
There was a problem hiding this comment.
Based on the lockfile changes, seems like you updated to Yarn 4?
There was a problem hiding this comment.
But it's not clear because this field is removed?
TheMythologist
force-pushed
the
use-node-events
branch
from
7608165 to
4970cb1
Compare
|
Done, apologies for the changes |
sorry, so what version of Yarn is being used? the package json is unchanged |
|
I left it as is (yarn 1) |
ok, I'll revert the lockfile in a bit as the lockfile is still using the Yarn 3 format |
RichDom2185
force-pushed
the
use-node-events
branch
from
edc1cc6 to
d401a3c
Compare
this works in the browser? |
|
Yup, it is |
RichDom2185
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
events-emitter-es6 package was causing TypeScript issues. Anyways, it has not been maintained for 7 years+, and there is now a core node module events.
Note: Will require creating a new release and update the dependency on frontend