-
Notifications
You must be signed in to change notification settings - Fork 0
More syntax highlighting fix #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
oops didnt run the test files, will fix those |
For the regex literal detection, i just took it from a js textmate syntax file lol |
Was the |
Ah for some reason I had a merge conflict in my yarn.lock? When I reran yarn it fixed the merge conflict for me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Previously, multiline strings using \ to escape newlines did not highlight properly, this has been fixed

Additionally, using multiple divisions in the same line would cause it to be matched as an illegal regex expression, this has also been fixed

This fixes two more bugs for issue #42