Skip to content

More syntax highlighting fix #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

mug1wara26
Copy link
Collaborator

Previously, multiline strings using \ to escape newlines did not highlight properly, this has been fixed
image

Additionally, using multiple divisions in the same line would cause it to be matched as an illegal regex expression, this has also been fixed
image

This fixes two more bugs for issue #42

@mug1wara26 mug1wara26 requested a review from heyzec July 14, 2025 15:17
@mug1wara26
Copy link
Collaborator Author

oops didnt run the test files, will fix those

@mug1wara26
Copy link
Collaborator Author

For the regex literal detection, i just took it from a js textmate syntax file lol
furthermore, i'll make the LSP throw errors when it detects regexp expressions

@RichDom2185
Copy link
Member

Was the yarn.lock update intentional?

@mug1wara26
Copy link
Collaborator Author

Ah for some reason I had a merge conflict in my yarn.lock? When I reran yarn it fixed the merge conflict for me

@RichDom2185
Copy link
Member

I got it, seems like @heyzec switched to Yarn Berry in #18 but did not update the packageManager field in package.json resulting in a conflict with corepack. Will fix

Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants