Skip to content

Commit 61f4376

Browse files
authored
Fix(release): promoteToPublic.finalize github:pr update main target bug (#286)
Closes REL-1069 ## Problem The release pipeline has been systematically failing in the `promoteToPublic.finalize` workflow with this error: ``` Warning: 1 uncommitted change must be on a branch named differently than 'promote/release-v6.4.3889-update-main' ``` ## Root Cause The final `github:pr` step in the `promoteToPublic.finalize` workflow was incorrectly trying to create a PR from the current branch to itself: - **Current branch**: `promote/release-{{version}}-update-main` - **Target branch**: `promote/release-{{version}}-update-main` ❌ (same branch!) - **Should target**: `main` ✅ This happened because the variable `internal_branch` was set to the current branch name instead of the intended target branch. ### Test plan This will have to be tested on a release
1 parent b094dcb commit 61f4376

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

release.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -398,11 +398,11 @@ promoteToPublic:
398398
- name: "github:pr"
399399
cmd: |
400400
set -eu
401-
internal_branch="promote/release-{{version}}-update-main"
401+
# Create PR to merge release updates into main branch
402402
gh pr create \
403403
--fill \
404404
--draft \
405-
--base "$internal_branch" \
405+
--base main \
406406
--title "Update main: build {{version}}" \
407407
--body "Test plan: automated release PR, CI will perform additional checks"
408408
echo "🚢 Please check the associated CI build to ensure the process completed".

0 commit comments

Comments
 (0)