fix: Fix crash when inheriting from class defined in untyped code. (#42)

Encountered when indexing Homebrew/brew.

Author: varungandhi-src

scip_indexer/SCIPIndexer.cc

@@ -912,9 +912,17 @@ class CFGTraversal final {
                 isMethodFileStaticInit ||
                 method == gs.lookupStaticInitForClass(namedSym.asSymbolRef().asClassOrModuleRef().data(gs)->owner,
                                                       /*allowMissing*/ true);
-            ENFORCE(check);
-            auto status = this->scipState.saveDefinition(gs, file, namedSym, arg.loc);
-            ENFORCE(status.ok());
+            absl::Status status;
+            string kind;
+            if (check) {
+                status = this->scipState.saveDefinition(gs, file, namedSym, arg.loc);
+                kind = "definition";
+            } else {
+                status = this->scipState.saveReference(gs, file, namedSym, arg.loc, 0);
+                kind = "reference";
+            }
+            ENFORCE(status.ok(), "failed to save {} for {}\ncontext:\ninstruction: {}\nlocation: {}\n", kind,
+                    namedSym.showRaw(gs), binding.value.showRaw(gs, cfg), core::Loc(file, arg.loc).showRaw(gs));
             return true;
         };
 

test/scip/testdata/multifile/typed-false-mix/def_untyped.rb

@@ -0,0 +1,4 @@
+# typed: false
+
+class C
+end

test/scip/testdata/multifile/typed-false-mix/def_untyped.snapshot.rb

@@ -0,0 +1,5 @@
+ # typed: false
+ 
+ class C
+#      ^ definition [..] C#
+ end

test/scip/testdata/multifile/typed-false-mix/use_untyped.rb

@@ -0,0 +1,8 @@
+# typed: true
+
+require 'def_untyped'
+
+module N
+  class D < C
+  end
+end

test/scip/testdata/multifile/typed-false-mix/use_untyped.snapshot.rb

@@ -0,0 +1,11 @@
+ # typed: true
+ 
+ require 'def_untyped'
+ 
+ module N
+#       ^ definition [..] N#
+   class D < C
+#        ^ definition [..] N#D#
+#            ^ reference [..] C#
+   end
+ end