Fix crash with bad format string in parser error (#6133)

Author: jez

parser/Parser.cc

@@ -63,7 +63,7 @@ void explainError(core::GlobalState &gs, core::FileRef file, core::ErrorBuilder
                 if (lCurlyPos != string::npos && rCurlyPos != string::npos) {
                     replacement[lCurlyPos] = '(';
                     replacement[rCurlyPos] = ')';
-                    e.replaceWith("Replace the curly braces with parens", loc, replacement);
+                    e.replaceWith("Replace the curly braces with parens", loc, "{}", replacement);
                 }
             }
             break;

test/testdata/parser/crash_block_pass_suggestion.rb

@@ -0,0 +1,8 @@
+# typed: true
+
+class A
+  def example
+    example{&:"{}"}
+    #      ^^^^^^^^ error: block pass should not be enclosed in curly braces
+  end
+end

test/testdata/parser/crash_block_pass_suggestion.rb.autocorrects.exp

@@ -0,0 +1,10 @@
+# -- test/testdata/parser/crash_block_pass_suggestion.rb --
+# typed: true
+
+class A
+  def example
+    example(&:"{}")
+    #      ^^^^^^^^ error: block pass should not be enclosed in curly braces
+  end
+end
+# ------------------------------