WIP: Improve hover text for common kinds of symbols.

Author: varungandhi-src

src/FileIndexer.ts

@@ -142,9 +142,7 @@ export class FileIndexer {
       new lsiftyped.SymbolInformation({
         symbol: symbol.value,
         documentation: [
-          '```ts\n' +
-            this.checker.typeToString(this.checker.getTypeAtLocation(node)) +
-            '\n```',
+          '```ts\n' + this.signatureForDocumentation(node, sym) + '\n```',
           ts.displayPartsToString(sym.getDocumentationComment(this.checker)),
         ],
       })
@@ -322,6 +320,58 @@ export class FileIndexer {
     }
     return undefined
   }
+
+  private signatureForDocumentation(
+    node: ts.Node,
+    sym: ts.Symbol
+  ): string {
+    const kind = scriptElementKind(node, sym)
+    const type = (): string => this.checker.typeToString(this.checker.getTypeAtLocation(node))
+    switch (kind) {
+      case ts.ScriptElementKind.localVariableElement:
+      case ts.ScriptElementKind.variableElement:
+        return 'var ' + node.getText() + ': ' + type()
+      case ts.ScriptElementKind.memberVariableElement:
+        return '(property) ' + node.getText() + ': ' + type()
+      case ts.ScriptElementKind.parameterElement:
+        return '(parameter) ' + node.getText() + ': ' + type()
+      case ts.ScriptElementKind.constElement:
+        return 'const ' + node.getText() + ': ' + type()
+      case ts.ScriptElementKind.letElement:
+        return 'let ' + node.getText() + ': ' + type()
+      case ts.ScriptElementKind.alias:
+        return 'type ' + node.getText()
+      case ts.ScriptElementKind.classElement:
+      case ts.ScriptElementKind.localClassElement:
+        return 'class ' + node.getText()
+      case ts.ScriptElementKind.interfaceElement:
+        return 'interface ' + node.getText()
+      case ts.ScriptElementKind.enumElement:
+        return 'enum ' + node.getText()
+      case ts.ScriptElementKind.enumMemberElement: {
+        let suffix = ''
+        const declaration = sym.declarations?.[0]
+        if (declaration && ts.isEnumMember(declaration)) {
+          const constantValue = this.checker.getConstantValue(declaration)
+          if (constantValue) {
+            suffix = ' = ' + constantValue.toString()
+          }
+        }
+        return '(enum member) ' + node.getText() + suffix
+      }
+      case ts.ScriptElementKind.functionElement:
+        return 'function ' + node.getText() + type()
+      case ts.ScriptElementKind.memberFunctionElement:
+        return '(method) ' + node.getText() + type()
+      case ts.ScriptElementKind.memberGetAccessorElement:
+        return 'get ' + node.getText() + ': ' + type()
+      case ts.ScriptElementKind.memberSetAccessorElement:
+        return 'set ' + node.getText() + type()
+      case ts.ScriptElementKind.constructorImplementationElement:
+        return ''
+    }
+    return node.getText() + ': ' + type()
+  }
 }
 
 function isAnonymousContainerOfSymbols(node: ts.Node): boolean {
@@ -334,3 +384,56 @@ function isAnonymousContainerOfSymbols(node: ts.Node): boolean {
     ts.isVariableDeclarationList(node)
   )
 }
+
+function scriptElementKind(
+  node: ts.Node,
+  sym: ts.Symbol
+): ts.ScriptElementKind {
+  const flags = sym.getFlags()
+  if (flags & ts.SymbolFlags.TypeAlias) {
+    return ts.ScriptElementKind.alias
+  }
+  if (flags & ts.SymbolFlags.Class) {
+    return ts.ScriptElementKind.classElement
+  }
+  if (flags & ts.SymbolFlags.Interface) {
+    return ts.ScriptElementKind.interfaceElement
+  }
+  if (flags & ts.SymbolFlags.Enum) {
+    return ts.ScriptElementKind.enumElement
+  }
+  if (flags & ts.SymbolFlags.EnumMember) {
+    return ts.ScriptElementKind.enumMemberElement
+  }
+  if (flags & ts.SymbolFlags.Method) {
+    return ts.ScriptElementKind.memberFunctionElement
+  }
+  if (flags & ts.SymbolFlags.GetAccessor) {
+    return ts.ScriptElementKind.memberGetAccessorElement
+  }
+  if (flags & ts.SymbolFlags.SetAccessor) {
+    return ts.ScriptElementKind.memberSetAccessorElement
+  }
+  if (flags & ts.SymbolFlags.Constructor) {
+    return ts.ScriptElementKind.constructorImplementationElement
+  }
+  if (flags & ts.SymbolFlags.Function) {
+    return ts.ScriptElementKind.functionElement
+  }
+  if (flags & ts.SymbolFlags.Variable) {
+    if (ts_inline.isParameter(sym)) {
+      return ts.ScriptElementKind.parameterElement
+    }
+    if (node.flags & ts.NodeFlags.Const) {
+      return ts.ScriptElementKind.constElement
+    }
+    if (node.flags & ts.NodeFlags.Let) {
+      return ts.ScriptElementKind.letElement
+    }
+    return ts.ScriptElementKind.variableElement
+  }
+  if (flags & ts.SymbolFlags.ClassMember) {
+    return ts.ScriptElementKind.memberVariableElement
+  }
+  return ts.ScriptElementKind.unknown
+}

src/TypeScriptInternal.ts

@@ -36,3 +36,17 @@ function isVariableDeclarationInitializedToBareOrAccessedRequire(node: ts.Node):
 function isVariableDeclaration(node: ts.Node): node is ts.VariableDeclaration {
   return node.kind === ts.SyntaxKind.VariableDeclaration;
 }
+export function isParameter(sym: ts.Symbol): boolean {
+  // based on isFirstDeclarationOfSymbolParameter
+  const declaration = sym.declarations?.[0]
+  return !!ts.findAncestor(declaration, (node: ts.Node): boolean | 'quit' =>
+    ts.isParameter(node)
+      ? true
+      : ts.isBindingElement(node) ||
+        ts.isObjectBindingPattern(node) ||
+        ts.isArrayBindingPattern(node)
+      ? false
+      : 'quit'
+  )
+}
+