Skip to content

fixing sonarcube issues #1000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 24, 2025
Merged

fixing sonarcube issues #1000

merged 3 commits into from
Jul 24, 2025

Conversation

marilynel
Copy link
Contributor

No description provided.

Copy link

@stleary
Copy link
Owner

stleary commented Jul 20, 2025

What problem does this code solve?
Addresses SonarQube issues from recent commits. In the case of JSONObject populateMap(), there will be a marginal performance cost.
This is considered acceptable since bean parsing is not thought to be an especially common operation, and the cost is not high (2 method calls were added).

Does the code still compile with Java6?
Yes

Risks
Low

Changes to the API?
No

Will this require a new release?
No

Should the documentation be updated?
No

Does it break the unit tests?
No

Was any code refactored in this commit?
Yes, this PR is just refactoring

Review status
APPROVED

Starting 3-day comment window

@stleary stleary merged commit 82432f0 into stleary:master Jul 24, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants