Skip to content

Commit 26340ec

Browse files
authored
Merge pull request #1438 from fpistm/library_API
library: Wire/SPI: change default pins type
2 parents c89ce28 + 36d969d commit 26340ec

File tree

5 files changed

+15
-15
lines changed

5 files changed

+15
-15
lines changed

cores/arduino/pins_arduino.h

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -64,13 +64,13 @@ _Static_assert(NUM_ANALOG_INPUTS <= MAX_ANALOG_INPUTS,
6464
#define PIN_SPI_SCK 13
6565
#endif
6666

67-
static const uint8_t SS = PIN_SPI_SS;
68-
static const uint8_t SS1 = PIN_SPI_SS1;
69-
static const uint8_t SS2 = PIN_SPI_SS2;
70-
static const uint8_t SS3 = PIN_SPI_SS3;
71-
static const uint8_t MOSI = PIN_SPI_MOSI;
72-
static const uint8_t MISO = PIN_SPI_MISO;
73-
static const uint8_t SCK = PIN_SPI_SCK;
67+
static const uint32_t SS = PIN_SPI_SS;
68+
static const uint32_t SS1 = PIN_SPI_SS1;
69+
static const uint32_t SS2 = PIN_SPI_SS2;
70+
static const uint32_t SS3 = PIN_SPI_SS3;
71+
static const uint32_t MOSI = PIN_SPI_MOSI;
72+
static const uint32_t MISO = PIN_SPI_MISO;
73+
static const uint32_t SCK = PIN_SPI_SCK;
7474

7575
/* I2C Definitions */
7676
#ifndef PIN_WIRE_SDA
@@ -80,8 +80,8 @@ static const uint8_t SCK = PIN_SPI_SCK;
8080
#define PIN_WIRE_SCL 15
8181
#endif
8282

83-
static const uint8_t SDA = PIN_WIRE_SDA;
84-
static const uint8_t SCL = PIN_WIRE_SCL;
83+
static const uint32_t SDA = PIN_WIRE_SDA;
84+
static const uint32_t SCL = PIN_WIRE_SCL;
8585

8686
#ifdef __cplusplus
8787
extern "C" {

libraries/SPI/src/SPI.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ SPIClass::SPIClass() : _CSPinConfig(NO_CONFIG)
4343
* another CS pin and don't pass a CS pin as parameter to any functions
4444
* of the class.
4545
*/
46-
SPIClass::SPIClass(uint8_t mosi, uint8_t miso, uint8_t sclk, uint8_t ssel) : _CSPinConfig(NO_CONFIG)
46+
SPIClass::SPIClass(uint32_t mosi, uint32_t miso, uint32_t sclk, uint32_t ssel) : _CSPinConfig(NO_CONFIG)
4747
{
4848
_spi.pin_miso = digitalPinToPinName(miso);
4949
_spi.pin_mosi = digitalPinToPinName(mosi);

libraries/SPI/src/SPI.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ class SPISettings {
114114
class SPIClass {
115115
public:
116116
SPIClass();
117-
SPIClass(uint8_t mosi, uint8_t miso, uint8_t sclk, uint8_t ssel = (uint8_t)NC);
117+
SPIClass(uint32_t mosi, uint32_t miso, uint32_t sclk, uint32_t ssel = PNUM_NOT_DEFINED);
118118

119119
// setMISO/MOSI/SCLK/SSEL have to be called before begin()
120120
void setMISO(uint32_t miso)

libraries/Wire/src/Wire.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,15 +39,15 @@ TwoWire::TwoWire()
3939
_i2c.scl = digitalPinToPinName(SCL);
4040
}
4141

42-
TwoWire::TwoWire(uint8_t sda, uint8_t scl)
42+
TwoWire::TwoWire(uint32_t sda, uint32_t scl)
4343
{
4444
_i2c.sda = digitalPinToPinName(sda);
4545
_i2c.scl = digitalPinToPinName(scl);
4646
}
4747

4848
// Public Methods //////////////////////////////////////////////////////////////
4949

50-
void TwoWire::begin(uint8_t sda, uint8_t scl)
50+
void TwoWire::begin(uint32_t sda, uint32_t scl)
5151
{
5252
_i2c.sda = digitalPinToPinName(sda);
5353
_i2c.scl = digitalPinToPinName(scl);

libraries/Wire/src/Wire.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ class TwoWire : public Stream {
6464

6565
public:
6666
TwoWire();
67-
TwoWire(uint8_t sda, uint8_t scl);
67+
TwoWire(uint32_t sda, uint32_t scl);
6868
// setSCL/SDA have to be called before begin()
6969
void setSCL(uint32_t scl)
7070
{
@@ -83,7 +83,7 @@ class TwoWire : public Stream {
8383
_i2c.sda = sda;
8484
};
8585
void begin(bool generalCall = false);
86-
void begin(uint8_t, uint8_t);
86+
void begin(uint32_t, uint32_t);
8787
void begin(uint8_t, bool generalCall = false);
8888
void begin(int, bool generalCall = false);
8989
void end();

0 commit comments

Comments
 (0)