fix extension dependencies after extension creation

Author: soedirgo

migrations/db/migrations/20221207154255_create_pgsodium_and_vault.sql

@@ -6,6 +6,19 @@ grant pgsodium_keyiduser to postgres with admin option;
 grant pgsodium_keyholder to postgres with admin option;
 grant pgsodium_keymaker  to postgres with admin option;
 
-create extension if not exists supabase_vault;
+do $$
+begin
+  if not exists (select from pg_extension where extname = 'supabase_vault') then
+    create extension supabase_vault;
+    -- Creating the extension creates a table and creates a security label on the table.
+    -- Creating the security label triggers a function that recreates these objects.
+    -- Since the recreation happens in an extension script, these objects become owned by the `supabase_vault` extension.
+    -- This is an issue because then we can't drop the extension without also dropping these objects.
+    -- Thus we drop the dependency on the `supabase_vault` extension for these objects.
+    alter extension supabase_vault drop view pgsodium.decrypted_key;
+    alter extension supabase_vault drop function pgsodium.key_encrypt_secret;
+  end if;
+end;
+$$;
 
 -- migrate:down