-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
fix: abort and reschedule $effect.pre
when necessary
#16335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
No and no. Please don't do this. |
Since you are here...the original pr also caused this The problem is that since we are rescheduling the counter to prevent infinite loops increase instead of just staying at 0 and run over the 1001 effects, AND the derived being read in the effect for the first time increase the write version. Not sure what the fix is yet, leaving this out there just in case is obvious to you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Follow-up to #16280 (comment) — just a failing test for now so that we don't lose track of it
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.packages/svelte/src
, add a changeset (npx changeset
).Tests and linting
pnpm test
and lint the project withpnpm lint