From 8e8ba7143a561aa3edff78d21a640fb80fc5f3a9 Mon Sep 17 00:00:00 2001 From: baseballyama Date: Sun, 23 Apr 2023 14:43:59 +0900 Subject: [PATCH 1/3] use pnpm8 if CI runs on Node20. see: https://github.com/pnpm/pnpm/issues/6424 --- .github/workflows/ci.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index e1c62ac9bdd5..95c821a0efcd 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -1,7 +1,7 @@ name: CI on: push: - branches: [ master ] + branches: [master] pull_request: permissions: contents: read # to fetch code (actions/checkout) @@ -27,6 +27,8 @@ jobs: steps: - uses: actions/checkout@v3 - uses: pnpm/action-setup@v2.2.4 + with: + version: ${{ matrix.node-version == 20 && 8 || 7 }} - uses: actions/setup-node@v3 with: node-version: ${{ matrix.node-version }} @@ -45,7 +47,7 @@ jobs: - uses: actions/setup-node@v3 with: cache: pnpm - - run: 'pnpm i && pnpm lint' + - run: "pnpm i && pnpm lint" Unit: runs-on: ${{ matrix.os }} timeout-minutes: 10 From 4f446f33e7f67b08fdbc7637ca7f7a4561a5f1ff Mon Sep 17 00:00:00 2001 From: baseballyama Date: Sun, 23 Apr 2023 15:06:34 +0900 Subject: [PATCH 2/3] revert needless changes --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 95c821a0efcd..5385cf11c3a9 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -1,7 +1,7 @@ name: CI on: push: - branches: [master] + branches: [ master ] pull_request: permissions: contents: read # to fetch code (actions/checkout) @@ -47,7 +47,7 @@ jobs: - uses: actions/setup-node@v3 with: cache: pnpm - - run: "pnpm i && pnpm lint" + - run: 'pnpm i && pnpm lint' Unit: runs-on: ${{ matrix.os }} timeout-minutes: 10 From 1e85a49c809ed2cf91f41e994c1a82aa1c116704 Mon Sep 17 00:00:00 2001 From: Yuichiro Yamashita Date: Thu, 27 Apr 2023 05:25:35 +0900 Subject: [PATCH 3/3] Update .github/workflows/ci.yml Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com> --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 5385cf11c3a9..7a9e68c01dc9 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -28,7 +28,7 @@ jobs: - uses: actions/checkout@v3 - uses: pnpm/action-setup@v2.2.4 with: - version: ${{ matrix.node-version == 20 && 8 || 7 }} + version: ${{ matrix.node-version == 14 && 7 || 8 }} - uses: actions/setup-node@v3 with: node-version: ${{ matrix.node-version }}