save custom ordered list start index in render JSON #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
mportiz08
reviewed
Dec 8, 2021
Sources/SwiftDocC/SwiftDocC.docc/Resources/RenderNode.spec.json
Outdated
Show resolved
Hide resolved
QuietMisdreavus
force-pushed
the
list-numbering
branch
from
6a22699 to
e43661b
Compare
|
@swift-ci Please test |
franklinsch
reviewed
Dec 13, 2021
franklinsch
reviewed
Dec 13, 2021
Sources/SwiftDocC/Model/Rendering/Content/RenderBlockContent.swift
Outdated
Show resolved
Hide resolved
QuietMisdreavus
force-pushed
the
list-numbering
branch
from
e43661b to
b09a1af
Compare
QuietMisdreavus
force-pushed
the
list-numbering
branch
from
b09a1af to
3a06aab
Compare
1 task
QuietMisdreavus
force-pushed
the
list-numbering
branch
from
3a06aab to
8e1208d
Compare
|
Rebased to resolve merge conflict and to bring up to date with the swift-markdown PR. @swift-ci Please test |
franklinsch
approved these changes
Oct 5, 2022
Package.resolved
Outdated
| "branch": "main", | ||
| "revision": "69f31f83a5dca9a3401d3e8fc8ff74804b0dd0ca", | ||
| "branch": "list-numbering", | ||
| "revision": "0cdc7269aa395115e50b25f388ffd184a4f04787", |
There was a problem hiding this comment.
Small reminder to un-stage this before merging
QuietMisdreavus
force-pushed
the
list-numbering
branch
from
8e1208d to
a0c796b
Compare
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable: rdar://73847907
Summary
While cmark-gfm saves the starting index for an ordered list, swift-markdown currently discards this information. This PR is part of a set to preserve this starting index when rendering documentation.
Dependencies
swiftlang/swift-markdown#22
Testing
Add the following markdown to
Sources/SwiftDocC/SwiftDocC.docc/SwiftDocC.md:Steps:
$DOCC_HTML_DIRto the resultingdistdirectory.bin/preview-docsChecklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
./bin/testscript and it succeeded