fix cross-module-optimization builds and add the option -disable-cmo
#1019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
The driver splits the compile job into two jobs: one for creating the object file, one for emitting the swiftmodule. For the swiftmodule-job the driver adds -experimental-skip-non-inlinable-function-bodies-without-types. This breaks CMO, because in CMO, the inlinable-decision is not derived from the AST but done in the optimizer. As a quick hack we could disable -experimental-skip-non-inlinable-function-bodies-without-types. But for CMO, the two-job approach is highly problematic, because it risks the two compile jobs to get out of sync, e.g. by different command line options, indeterministic behavior, etc. This can result in unresolved symbol errors, which are very hard to debug. This change also adds a new option `-disable-cmo` to disable cross-module-optimization. It can be used to go back to the old behavior. rdar://89223981
eeckstein
force-pushed
the
fix-cmo-builds
branch
from
74fdd55 to
5b4f5dd
Compare
|
@swift-ci test |
artemcm
reviewed
Feb 23, 2022
| @@ -61,6 +61,7 @@ extension Option { | |||
| public static let continueBuildingAfterErrors: Option = Option("-continue-building-after-errors", .flag, attributes: [.frontend, .doesNotAffectIncrementalBuild], helpText: "Continue building, even after errors are encountered") | |||
| public static let coveragePrefixMap: Option = Option("-coverage-prefix-map", .separate, attributes: [.frontend], metaVar: "<prefix=replacement>", helpText: "Remap source paths in coverage info") | |||
| public static let CrossModuleOptimization: Option = Option("-cross-module-optimization", .flag, attributes: [.helpHidden, .frontend], helpText: "Perform cross-module optimization") | |||
| public static let disableCrossModuleOptimization: Option = Option("-disable-cmo", .flag, attributes: [.helpHidden, .frontend], helpText: "Disable cross-module optimization") | |||
There was a problem hiding this comment.
Please update Options.swift according to the procedure described in:
https://github.com/apple/swift-driver#rebuilding-optionsswift
There was a problem hiding this comment.
ok, I'll do this in a separate PR
artemcm
approved these changes
Feb 23, 2022
xymus
approved these changes
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The driver splits the compile job into two jobs: one for creating the object file, one for emitting the swiftmodule.
For the swiftmodule-job the driver adds -experimental-skip-non-inlinable-function-bodies-without-types.
This breaks CMO, because in CMO, the inlinable-decision is not derived from the AST but done in the optimizer.
As a quick hack we could disable -experimental-skip-non-inlinable-function-bodies-without-types.
But for CMO, the two-job approach is highly problematic, because it risks the two compile jobs to get out of sync, e.g. by different command line options, indeterministic behavior, etc. This can result in unresolved symbol errors, which are very hard to debug.
This change also adds a new option
-disable-cmoto disable cross-module-optimization. It can be used to go back to the old behavior.rdar://89223981