Fix Data Base64 length encoding bug #1425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
parkera
reviewed
Jul 11, 2025
| #expect(stringBase64 == String(decoding: dataBase64, as: Unicode.UTF8.self)) | ||
| } | ||
|
|
||
| for count in 0..<10_000 { |
There was a problem hiding this comment.
Why 10,000? If it takes a while to run and doesn’t provide additional code coverage it might be better to pick a lower number.
There was a problem hiding this comment.
Fixed to 1_000 and parameterized the test:
Test testBase64DataOutputMatchesStingOutput(options:) started.
Test case passing 1 argument options → Base64EncodingOptions(rawValue: 33) to testBase64DataOutputMatchesStingOutput(options:) started.
Test case passing 1 argument options → Base64EncodingOptions(rawValue: 17) to testBase64DataOutputMatchesStingOutput(options:) started.
Test case passing 1 argument options → Base64EncodingOptions(rawValue: 2) to testBase64DataOutputMatchesStingOutput(options:) started.
Test case passing 1 argument options → Base64EncodingOptions(rawValue: 0) to testBase64DataOutputMatchesStingOutput(options:) started.
Test case passing 1 argument options → Base64EncodingOptions(rawValue: 1) to testBase64DataOutputMatchesStingOutput(options:) started.
Test testBase64DataOutputMatchesStingOutput(options:) with 5 test cases passed after 0.061 seconds.
|
Test failures are known and I just fixed/disabled those tests. |
|
@swift-ci please test |
### Motivation We have an issue in encodeComputeCapacity. If we add lineBreaks, we assumed to add line breaks for lines that ended at the max capacity. ### Changes - encodeComputeCapacity checks if the last line uses the full length and removes unnecessary seperatorBytes if needed rdar://155204772
fabianfett
force-pushed
the
ff-fix-base64-data-length-encoding-bug
branch
from
2b34d0c to
56dde3d
Compare
|
@swift-ci test |
itingliu
approved these changes
Jul 14, 2025
|
Thanks @fabianfett |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We have an issue in
encodeComputeCapacity. If we add lineBreaks, we assumed to add line breaks for lines that ended at the max capacity.Changes
encodeComputeCapacitychecks if the last line uses the full length and removes unnecessary seperatorBytes if neededrdar://155204772