Fix remaining FormatStyle caches of autoupdating locales #342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and an autoupdating locale will not cause a refreshed format. Follows up on 18ac5ac (swiftlang#334) Fixes rdar://119010483
|
@swift-ci test |
itingliu
approved these changes
Dec 8, 2023
| let formatter = Self.cache.formatter(for: format) { | ||
| ICURelativeDateFormatter(uNumberFormatStyle: format.unitsStyle.icuNumberFormatStyle, uRelDateStyle: format.unitsStyle.icuRelativeDateStyle, locale: format.locale, context: format.capitalizationContext.icuContext) | ||
| internal static func formatter(for style: Date.RelativeFormatStyle) -> ICURelativeDateFormatter { | ||
| let signature = Signature(localeIdentifier: style.locale.identifier, numberFormatStyle: style.unitsStyle.icuNumberFormatStyle?.rawValue, relativeDateStyle: style.unitsStyle.icuRelativeDateStyle.rawValue, context: style.capitalizationContext.icuContext.rawValue) |
There was a problem hiding this comment.
Should this be the preference-capturing locale identifier to account for, say, custom first weekday? I imagine that information would be useful for calculating relative date in terms of weeks
There was a problem hiding this comment.
Hm, that may be another bug. I'll file one to check if ICURelativeDateFormatter should be using preference-capturing locale.
parkera
added a commit
to parkera/swift-foundation
that referenced
this pull request
Dec 11, 2023
… locale for testing purposes. Follow up for swiftlang#342
itingliu
pushed a commit
to itingliu/swift-foundation
that referenced
this pull request
Dec 12, 2023
…and an autoupdating locale will not cause a refreshed format. (swiftlang#342) Follows up on 18ac5ac (swiftlang#334) Fixes rdar://119010483
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix up remaining issues where we cache a
Localefor format styles, and an autoupdating locale will not cause a refreshed format.Follows up on 18ac5ac (#334 )
Fixes rdar://119010483