From 00bb26aec51a5815d95903d1e1aff21d833c8228 Mon Sep 17 00:00:00 2001 From: Tristan Labelle Date: Thu, 30 Mar 2023 15:24:03 -0400 Subject: [PATCH 1/6] Fix regression on default install dir after wix v4 port --- platforms/Windows/devtools-amd64.wxs | 4 +--- platforms/Windows/devtools-arm64.wxs | 4 +--- platforms/Windows/runtime-amd64.wxs | 6 ++---- platforms/Windows/runtime-arm64.wxs | 5 +---- platforms/Windows/runtime-x86.wxs | 4 +--- platforms/Windows/sdk-amd64.wxs | 5 +---- platforms/Windows/sdk-arm64.wxs | 4 +--- platforms/Windows/sdk-x86.wxs | 4 +--- platforms/Windows/swift-format-amd64.wxs | 4 +--- platforms/Windows/swift-format-arm64.wxs | 4 +--- platforms/Windows/toolchain-amd64.wxs | 5 +---- platforms/Windows/toolchain-arm64.wxs | 4 +--- 12 files changed, 13 insertions(+), 40 deletions(-) diff --git a/platforms/Windows/devtools-amd64.wxs b/platforms/Windows/devtools-amd64.wxs index 77fe229a..8885010e 100644 --- a/platforms/Windows/devtools-amd64.wxs +++ b/platforms/Windows/devtools-amd64.wxs @@ -14,7 +14,7 @@ - + @@ -38,8 +38,6 @@ - - diff --git a/platforms/Windows/devtools-arm64.wxs b/platforms/Windows/devtools-arm64.wxs index ffa787f6..a5c0f74a 100644 --- a/platforms/Windows/devtools-arm64.wxs +++ b/platforms/Windows/devtools-arm64.wxs @@ -14,7 +14,7 @@ - + @@ -38,8 +38,6 @@ - - diff --git a/platforms/Windows/runtime-amd64.wxs b/platforms/Windows/runtime-amd64.wxs index 544d7392..514dd64d 100644 --- a/platforms/Windows/runtime-amd64.wxs +++ b/platforms/Windows/runtime-amd64.wxs @@ -14,7 +14,7 @@ - + @@ -22,9 +22,7 @@ - - - + diff --git a/platforms/Windows/runtime-arm64.wxs b/platforms/Windows/runtime-arm64.wxs index de5e8dad..ad2d5275 100644 --- a/platforms/Windows/runtime-arm64.wxs +++ b/platforms/Windows/runtime-arm64.wxs @@ -14,7 +14,7 @@ - + @@ -23,9 +23,6 @@ - - - diff --git a/platforms/Windows/runtime-x86.wxs b/platforms/Windows/runtime-x86.wxs index 52edaf5b..da46c9ba 100644 --- a/platforms/Windows/runtime-x86.wxs +++ b/platforms/Windows/runtime-x86.wxs @@ -14,7 +14,7 @@ - + @@ -23,8 +23,6 @@ - - diff --git a/platforms/Windows/sdk-amd64.wxs b/platforms/Windows/sdk-amd64.wxs index 68f2740f..5f63cde2 100644 --- a/platforms/Windows/sdk-amd64.wxs +++ b/platforms/Windows/sdk-amd64.wxs @@ -14,7 +14,7 @@ - + @@ -109,9 +109,6 @@ - - - diff --git a/platforms/Windows/sdk-arm64.wxs b/platforms/Windows/sdk-arm64.wxs index 6f13c2a4..f4ceab71 100644 --- a/platforms/Windows/sdk-arm64.wxs +++ b/platforms/Windows/sdk-arm64.wxs @@ -14,7 +14,7 @@ - + @@ -110,8 +110,6 @@ - - diff --git a/platforms/Windows/sdk-x86.wxs b/platforms/Windows/sdk-x86.wxs index 22871eb4..b7c21be8 100644 --- a/platforms/Windows/sdk-x86.wxs +++ b/platforms/Windows/sdk-x86.wxs @@ -14,7 +14,7 @@ - + @@ -109,8 +109,6 @@ - - diff --git a/platforms/Windows/swift-format-amd64.wxs b/platforms/Windows/swift-format-amd64.wxs index 7a188eda..62155b8a 100644 --- a/platforms/Windows/swift-format-amd64.wxs +++ b/platforms/Windows/swift-format-amd64.wxs @@ -15,15 +15,13 @@ - + - - diff --git a/platforms/Windows/swift-format-arm64.wxs b/platforms/Windows/swift-format-arm64.wxs index a64de654..c502c2ef 100644 --- a/platforms/Windows/swift-format-arm64.wxs +++ b/platforms/Windows/swift-format-arm64.wxs @@ -15,15 +15,13 @@ - + - - diff --git a/platforms/Windows/toolchain-amd64.wxs b/platforms/Windows/toolchain-amd64.wxs index 4b732407..a2cc3c17 100644 --- a/platforms/Windows/toolchain-amd64.wxs +++ b/platforms/Windows/toolchain-amd64.wxs @@ -34,7 +34,7 @@ - + diff --git a/platforms/Windows/toolchain-arm64.wxs b/platforms/Windows/toolchain-arm64.wxs index b05101c1..482ff5b6 100644 --- a/platforms/Windows/toolchain-arm64.wxs +++ b/platforms/Windows/toolchain-arm64.wxs @@ -34,7 +34,7 @@ - + From 5da593a7957f923a43cbf701b2f19709fda409ec Mon Sep 17 00:00:00 2001 From: Tristan Labelle Date: Fri, 31 Mar 2023 10:14:47 -0400 Subject: [PATCH 2/6] Switched to StandardDirectory for runtime wxs --- platforms/Windows/runtime-amd64.wxs | 14 ++++++++------ platforms/Windows/runtime-arm64.wxs | 14 ++++++++------ platforms/Windows/runtime-x86.wxs | 14 ++++++++------ 3 files changed, 24 insertions(+), 18 deletions(-) diff --git a/platforms/Windows/runtime-amd64.wxs b/platforms/Windows/runtime-amd64.wxs index 514dd64d..429a4ae8 100644 --- a/platforms/Windows/runtime-amd64.wxs +++ b/platforms/Windows/runtime-amd64.wxs @@ -14,15 +14,17 @@ - - - - - + + + + + + + - + diff --git a/platforms/Windows/runtime-arm64.wxs b/platforms/Windows/runtime-arm64.wxs index ad2d5275..06c8f099 100644 --- a/platforms/Windows/runtime-arm64.wxs +++ b/platforms/Windows/runtime-arm64.wxs @@ -14,15 +14,17 @@ - - - - - + + + + + + + - + diff --git a/platforms/Windows/runtime-x86.wxs b/platforms/Windows/runtime-x86.wxs index da46c9ba..95543507 100644 --- a/platforms/Windows/runtime-x86.wxs +++ b/platforms/Windows/runtime-x86.wxs @@ -14,15 +14,17 @@ - - - - - + + + + + + + - + From 52f8977a3208f49ce9f50e2f6142f9bdd845880e Mon Sep 17 00:00:00 2001 From: Tristan Labelle Date: Fri, 31 Mar 2023 10:27:16 -0400 Subject: [PATCH 3/6] Fixed WindowsVolume reference for C:\Library-targeting wxs's --- platforms/Windows/devtools-amd64.wxs | 32 ++--- platforms/Windows/devtools-arm64.wxs | 32 ++--- platforms/Windows/sdk-amd64.wxs | 145 +++++++++++----------- platforms/Windows/sdk-arm64.wxs | 146 ++++++++++++----------- platforms/Windows/sdk-x86.wxs | 146 ++++++++++++----------- platforms/Windows/swift-format-amd64.wxs | 11 +- platforms/Windows/swift-format-arm64.wxs | 10 +- platforms/Windows/toolchain-amd64.wxs | 106 ++++++++-------- platforms/Windows/toolchain-arm64.wxs | 108 +++++++++-------- 9 files changed, 386 insertions(+), 350 deletions(-) diff --git a/platforms/Windows/devtools-amd64.wxs b/platforms/Windows/devtools-amd64.wxs index 8885010e..7d3775ca 100644 --- a/platforms/Windows/devtools-amd64.wxs +++ b/platforms/Windows/devtools-amd64.wxs @@ -14,20 +14,24 @@ - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + diff --git a/platforms/Windows/devtools-arm64.wxs b/platforms/Windows/devtools-arm64.wxs index a5c0f74a..169543be 100644 --- a/platforms/Windows/devtools-arm64.wxs +++ b/platforms/Windows/devtools-arm64.wxs @@ -14,20 +14,24 @@ - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + diff --git a/platforms/Windows/sdk-amd64.wxs b/platforms/Windows/sdk-amd64.wxs index 5f63cde2..2eb86544 100644 --- a/platforms/Windows/sdk-amd64.wxs +++ b/platforms/Windows/sdk-amd64.wxs @@ -14,92 +14,95 @@ - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + - - + - - - - - - - - - - - - + + + + + - - - - - + - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + - + + + + + - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + - - + + diff --git a/platforms/Windows/sdk-arm64.wxs b/platforms/Windows/sdk-arm64.wxs index f4ceab71..f10f8b2c 100644 --- a/platforms/Windows/sdk-arm64.wxs +++ b/platforms/Windows/sdk-arm64.wxs @@ -14,92 +14,96 @@ - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + - - + - - - - - - - - - - - - + + + + + - - - - - + - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + - + + + + + - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + - - + + diff --git a/platforms/Windows/sdk-x86.wxs b/platforms/Windows/sdk-x86.wxs index b7c21be8..9a02446d 100644 --- a/platforms/Windows/sdk-x86.wxs +++ b/platforms/Windows/sdk-x86.wxs @@ -14,92 +14,96 @@ - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + - - + - - - - - - - - - - - - + + + + + - - - - - + - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + - + + + + + - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + - - + + diff --git a/platforms/Windows/swift-format-amd64.wxs b/platforms/Windows/swift-format-amd64.wxs index 62155b8a..854cf78e 100644 --- a/platforms/Windows/swift-format-amd64.wxs +++ b/platforms/Windows/swift-format-amd64.wxs @@ -15,9 +15,14 @@ - - - + + + + + + + + diff --git a/platforms/Windows/swift-format-arm64.wxs b/platforms/Windows/swift-format-arm64.wxs index c502c2ef..bff5823f 100644 --- a/platforms/Windows/swift-format-arm64.wxs +++ b/platforms/Windows/swift-format-arm64.wxs @@ -15,9 +15,13 @@ - - - + + + + + + + diff --git a/platforms/Windows/toolchain-amd64.wxs b/platforms/Windows/toolchain-amd64.wxs index a2cc3c17..b92e431b 100644 --- a/platforms/Windows/toolchain-amd64.wxs +++ b/platforms/Windows/toolchain-amd64.wxs @@ -34,65 +34,69 @@ - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + - - - - - + + + + + + + + + + + + + + + + + - - - - + + + + + + + + + + - + + + + + - - - - - + - - - - - + + + diff --git a/platforms/Windows/toolchain-arm64.wxs b/platforms/Windows/toolchain-arm64.wxs index 482ff5b6..9173fea4 100644 --- a/platforms/Windows/toolchain-arm64.wxs +++ b/platforms/Windows/toolchain-arm64.wxs @@ -34,72 +34,76 @@ - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + - - - - - + + + + + + + + + + + + + + + + + - - - - + + + + + + + + + + - + + + + + - - - - - + - - - - - + + + - + From c917be4ff05daad9b685d0e949ce5256ba788011 Mon Sep 17 00:00:00 2001 From: Tristan Labelle Date: Fri, 31 Mar 2023 11:10:37 -0400 Subject: [PATCH 4/6] Capitalized Swift under Program Files --- platforms/Windows/runtime-amd64.wxs | 2 +- platforms/Windows/runtime-arm64.wxs | 2 +- platforms/Windows/runtime-x86.wxs | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/platforms/Windows/runtime-amd64.wxs b/platforms/Windows/runtime-amd64.wxs index 429a4ae8..b972a331 100644 --- a/platforms/Windows/runtime-amd64.wxs +++ b/platforms/Windows/runtime-amd64.wxs @@ -15,7 +15,7 @@ - + diff --git a/platforms/Windows/runtime-arm64.wxs b/platforms/Windows/runtime-arm64.wxs index 06c8f099..300716a6 100644 --- a/platforms/Windows/runtime-arm64.wxs +++ b/platforms/Windows/runtime-arm64.wxs @@ -15,7 +15,7 @@ - + diff --git a/platforms/Windows/runtime-x86.wxs b/platforms/Windows/runtime-x86.wxs index 95543507..13ae099a 100644 --- a/platforms/Windows/runtime-x86.wxs +++ b/platforms/Windows/runtime-x86.wxs @@ -15,7 +15,7 @@ - + From 60d61ead1d8476ffc0aa4d472e4cba5889763703 Mon Sep 17 00:00:00 2001 From: Tristan Labelle Date: Fri, 31 Mar 2023 11:31:55 -0400 Subject: [PATCH 5/6] Change overridable install dir to the level above Library --- platforms/Windows/devtools-amd64.wxs | 30 ++--- platforms/Windows/devtools-arm64.wxs | 30 ++--- platforms/Windows/sdk-amd64.wxs | 146 ++++++++++++----------- platforms/Windows/sdk-arm64.wxs | 146 ++++++++++++----------- platforms/Windows/swift-format-amd64.wxs | 10 +- platforms/Windows/swift-format-arm64.wxs | 10 +- platforms/Windows/toolchain-amd64.wxs | 108 +++++++++-------- platforms/Windows/toolchain-arm64.wxs | 110 ++++++++--------- 8 files changed, 303 insertions(+), 287 deletions(-) diff --git a/platforms/Windows/devtools-amd64.wxs b/platforms/Windows/devtools-amd64.wxs index 7d3775ca..62004e20 100644 --- a/platforms/Windows/devtools-amd64.wxs +++ b/platforms/Windows/devtools-amd64.wxs @@ -17,20 +17,22 @@ - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + diff --git a/platforms/Windows/devtools-arm64.wxs b/platforms/Windows/devtools-arm64.wxs index 169543be..b9249c5d 100644 --- a/platforms/Windows/devtools-arm64.wxs +++ b/platforms/Windows/devtools-arm64.wxs @@ -17,20 +17,22 @@ - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + diff --git a/platforms/Windows/sdk-amd64.wxs b/platforms/Windows/sdk-amd64.wxs index 2eb86544..f16f3547 100644 --- a/platforms/Windows/sdk-amd64.wxs +++ b/platforms/Windows/sdk-amd64.wxs @@ -16,92 +16,94 @@ - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + - - + - - - - - - - - - - - - + + + + + - - - - - + - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + - + + + + + - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + - - + + @@ -488,7 +490,7 @@ - + diff --git a/platforms/Windows/sdk-arm64.wxs b/platforms/Windows/sdk-arm64.wxs index f10f8b2c..6a799ada 100644 --- a/platforms/Windows/sdk-arm64.wxs +++ b/platforms/Windows/sdk-arm64.wxs @@ -17,92 +17,94 @@ - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + - - + - - - - - - - - - - - - + + + + + - - - - - + - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + - + + + + + - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + - - + + @@ -489,7 +491,7 @@ - + diff --git a/platforms/Windows/swift-format-amd64.wxs b/platforms/Windows/swift-format-amd64.wxs index 854cf78e..8fb32be2 100644 --- a/platforms/Windows/swift-format-amd64.wxs +++ b/platforms/Windows/swift-format-amd64.wxs @@ -19,9 +19,11 @@ - - - + + + + + @@ -43,7 +45,7 @@ - + diff --git a/platforms/Windows/swift-format-arm64.wxs b/platforms/Windows/swift-format-arm64.wxs index bff5823f..52b36bb9 100644 --- a/platforms/Windows/swift-format-arm64.wxs +++ b/platforms/Windows/swift-format-arm64.wxs @@ -18,9 +18,11 @@ - - - + + + + + @@ -42,7 +44,7 @@ - + diff --git a/platforms/Windows/toolchain-amd64.wxs b/platforms/Windows/toolchain-amd64.wxs index b92e431b..d5603f51 100644 --- a/platforms/Windows/toolchain-amd64.wxs +++ b/platforms/Windows/toolchain-amd64.wxs @@ -37,65 +37,67 @@ - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + - - - - - + + + + + + + + + + + + + + + + + - - - - + + + + + + + + + + - + + + + + - - - - - + - - - - - + + + @@ -760,8 +762,8 @@ - - + + diff --git a/platforms/Windows/toolchain-arm64.wxs b/platforms/Windows/toolchain-arm64.wxs index 9173fea4..2078aece 100644 --- a/platforms/Windows/toolchain-arm64.wxs +++ b/platforms/Windows/toolchain-arm64.wxs @@ -37,65 +37,67 @@ - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + - - - - - + + + + + + + + + + + + + + + + + - - - - + + + + + + + + + + - + + + + + - - - - - + - - - - - + + + @@ -103,7 +105,7 @@ - + @@ -760,8 +762,8 @@ - - + + From 623d9066d6eed01a9765c185ada3a3fe6f0c6237 Mon Sep 17 00:00:00 2001 From: Tristan Labelle Date: Fri, 31 Mar 2023 11:53:32 -0400 Subject: [PATCH 6/6] Uniformize comments --- platforms/Windows/sdk-amd64.wxs | 1 + platforms/Windows/swift-format-amd64.wxs | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/platforms/Windows/sdk-amd64.wxs b/platforms/Windows/sdk-amd64.wxs index f16f3547..2edecccf 100644 --- a/platforms/Windows/sdk-amd64.wxs +++ b/platforms/Windows/sdk-amd64.wxs @@ -14,6 +14,7 @@ + diff --git a/platforms/Windows/swift-format-amd64.wxs b/platforms/Windows/swift-format-amd64.wxs index 8fb32be2..a57d68f6 100644 --- a/platforms/Windows/swift-format-amd64.wxs +++ b/platforms/Windows/swift-format-amd64.wxs @@ -15,7 +15,6 @@ -