From 84b5a4522b47122fb70cfebcef4a7c02fd91f8d6 Mon Sep 17 00:00:00 2001 From: Mohamed Hegazy Date: Wed, 11 Jun 2025 16:55:21 -0700 Subject: [PATCH 1/4] Rename toolchain directory id from ToolchainsVersioned to ToolchainsVersionedAsserts --- platforms/Windows/bld/bld.wxi | 2 +- platforms/Windows/shared/shared.wxs | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/platforms/Windows/bld/bld.wxi b/platforms/Windows/bld/bld.wxi index d556b457..8f29c416 100644 --- a/platforms/Windows/bld/bld.wxi +++ b/platforms/Windows/bld/bld.wxi @@ -539,7 +539,7 @@ - + diff --git a/platforms/Windows/shared/shared.wxs b/platforms/Windows/shared/shared.wxs index 2cb4b706..e6e35583 100644 --- a/platforms/Windows/shared/shared.wxs +++ b/platforms/Windows/shared/shared.wxs @@ -38,7 +38,7 @@ - + @@ -86,8 +86,8 @@ - - + + @@ -103,8 +103,8 @@ - - + + From ee963099ceba1e1e64c2909eddce7960073f5480 Mon Sep 17 00:00:00 2001 From: Mohamed Hegazy Date: Wed, 11 Jun 2025 19:54:29 -0700 Subject: [PATCH 2/4] Use toolchain variant name in directory ids --- .../Windows/bld/asserts/bld.asserts.wixproj | 4 +- platforms/Windows/bld/bld.wxi | 90 +++++++++---------- .../Windows/cli/asserts/cli.asserts.wixproj | 2 +- platforms/Windows/cli/cli.wxi | 88 +++++++++--------- platforms/Windows/dbg/dbg.wxi | 66 +++++++------- platforms/Windows/ide/ide.wxi | 20 ++--- platforms/Windows/shared/shared.wxs | 20 ++--- 7 files changed, 145 insertions(+), 145 deletions(-) diff --git a/platforms/Windows/bld/asserts/bld.asserts.wixproj b/platforms/Windows/bld/asserts/bld.asserts.wixproj index 6a59aff4..9d8dc091 100644 --- a/platforms/Windows/bld/asserts/bld.asserts.wixproj +++ b/platforms/Windows/bld/asserts/bld.asserts.wixproj @@ -16,7 +16,7 @@ ClangResources_asserts - _usr_lib_clang + toolchains_asserts_usr_lib_clang var._USR_LIB_CLANG true true @@ -27,7 +27,7 @@ SwiftClangResources_asserts - _usr_lib_swift_clang + toolchains_asserts_usr_lib_swift_clang var._USR_LIB_SWIFT_CLANG true true diff --git a/platforms/Windows/bld/bld.wxi b/platforms/Windows/bld/bld.wxi index 8f29c416..dcdce42e 100644 --- a/platforms/Windows/bld/bld.wxi +++ b/platforms/Windows/bld/bld.wxi @@ -16,28 +16,28 @@ - - - + + + - - - + + + - - - - - - + + + + + + - + @@ -46,7 +46,7 @@ - + @@ -145,26 +145,26 @@ - + - + - + - + - + @@ -195,7 +195,7 @@ --> - + @@ -215,11 +215,11 @@ - + - + @@ -227,18 +227,18 @@ - + - + - + @@ -249,27 +249,27 @@ - + - + - + - + - + - + @@ -308,13 +308,13 @@ - + - + @@ -347,7 +347,7 @@ - + @@ -372,7 +372,7 @@ - + @@ -381,25 +381,25 @@ - + - + - + - + @@ -408,7 +408,7 @@ - + @@ -432,7 +432,7 @@ - + @@ -474,7 +474,7 @@ - + @@ -516,7 +516,7 @@ - + @@ -525,7 +525,7 @@ - + @@ -545,7 +545,7 @@ - + diff --git a/platforms/Windows/cli/asserts/cli.asserts.wixproj b/platforms/Windows/cli/asserts/cli.asserts.wixproj index 40eba18b..2a3c0750 100644 --- a/platforms/Windows/cli/asserts/cli.asserts.wixproj +++ b/platforms/Windows/cli/asserts/cli.asserts.wixproj @@ -17,7 +17,7 @@ DocCRender_asserts - _usr_share_docc_render + toolchains_asserts_usr_share_docc_render var.SWIFT_DOCC_RENDER_ARTIFACT_ROOT_DIST true true diff --git a/platforms/Windows/cli/cli.wxi b/platforms/Windows/cli/cli.wxi index 2bec3125..0a92edac 100644 --- a/platforms/Windows/cli/cli.wxi +++ b/platforms/Windows/cli/cli.wxi @@ -16,33 +16,33 @@ - - - - + + + + - + - - + + - - - - - - - - - - + + + + + + + + + + - + @@ -56,12 +56,12 @@ - - + + - + @@ -94,12 +94,12 @@ - - + + - + @@ -111,12 +111,12 @@ - - + + - + @@ -131,7 +131,7 @@ - + @@ -146,13 +146,13 @@ - + - + @@ -167,7 +167,7 @@ - + @@ -182,7 +182,7 @@ - + @@ -197,12 +197,12 @@ - + - + @@ -414,7 +414,7 @@ - + @@ -425,7 +425,7 @@ - + @@ -439,7 +439,7 @@ - + @@ -453,7 +453,7 @@ - + @@ -545,7 +545,7 @@ - + @@ -559,7 +559,7 @@ - + @@ -574,7 +574,7 @@ - + @@ -655,7 +655,7 @@ - + @@ -719,7 +719,7 @@ - + @@ -727,7 +727,7 @@ - + diff --git a/platforms/Windows/dbg/dbg.wxi b/platforms/Windows/dbg/dbg.wxi index 8d9273e0..f8a1e897 100644 --- a/platforms/Windows/dbg/dbg.wxi +++ b/platforms/Windows/dbg/dbg.wxi @@ -16,117 +16,117 @@ - - + + - + - - - + + + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - - + + - + diff --git a/platforms/Windows/ide/ide.wxi b/platforms/Windows/ide/ide.wxi index 46e22e45..4ad5e146 100644 --- a/platforms/Windows/ide/ide.wxi +++ b/platforms/Windows/ide/ide.wxi @@ -16,45 +16,45 @@ - - + + - + - + - + - + - + - + - + - + diff --git a/platforms/Windows/shared/shared.wxs b/platforms/Windows/shared/shared.wxs index e6e35583..d261bf39 100644 --- a/platforms/Windows/shared/shared.wxs +++ b/platforms/Windows/shared/shared.wxs @@ -39,21 +39,21 @@ - - - - - - - + + + + + + + - - - + + + From 4134a4c0b9a51634ba26ec4ba2ee26d73f44e85b Mon Sep 17 00:00:00 2001 From: Mohamed Hegazy Date: Thu, 26 Jun 2025 15:04:10 -0700 Subject: [PATCH 3/4] use toolchain instead of toolchains in directory ids --- .../Windows/bld/asserts/bld.asserts.wixproj | 4 +- platforms/Windows/bld/bld.wxi | 92 +++++++++---------- .../Windows/cli/asserts/cli.asserts.wixproj | 2 +- platforms/Windows/cli/cli.wxi | 88 +++++++++--------- platforms/Windows/dbg/dbg.wxi | 66 ++++++------- platforms/Windows/ide/ide.wxi | 20 ++-- platforms/Windows/shared/shared.wxs | 30 +++--- 7 files changed, 151 insertions(+), 151 deletions(-) diff --git a/platforms/Windows/bld/asserts/bld.asserts.wixproj b/platforms/Windows/bld/asserts/bld.asserts.wixproj index 9d8dc091..ccd7873a 100644 --- a/platforms/Windows/bld/asserts/bld.asserts.wixproj +++ b/platforms/Windows/bld/asserts/bld.asserts.wixproj @@ -16,7 +16,7 @@ ClangResources_asserts - toolchains_asserts_usr_lib_clang + toolchain_asserts_usr_lib_clang var._USR_LIB_CLANG true true @@ -27,7 +27,7 @@ SwiftClangResources_asserts - toolchains_asserts_usr_lib_swift_clang + toolchain_asserts_usr_lib_swift_clang var._USR_LIB_SWIFT_CLANG true true diff --git a/platforms/Windows/bld/bld.wxi b/platforms/Windows/bld/bld.wxi index dcdce42e..a14083c6 100644 --- a/platforms/Windows/bld/bld.wxi +++ b/platforms/Windows/bld/bld.wxi @@ -16,28 +16,28 @@ - - - + + + - - - + + + - - - - - - + + + + + + - + @@ -46,7 +46,7 @@ - + @@ -145,26 +145,26 @@ - + - + - + - + - + @@ -195,7 +195,7 @@ --> - + @@ -215,11 +215,11 @@ - + - + @@ -227,18 +227,18 @@ - + - + - + @@ -249,27 +249,27 @@ - + - + - + - + - + - + @@ -308,13 +308,13 @@ - + - + @@ -347,7 +347,7 @@ - + @@ -372,7 +372,7 @@ - + @@ -381,25 +381,25 @@ - + - + - + - + @@ -408,7 +408,7 @@ - + @@ -432,7 +432,7 @@ - + @@ -474,7 +474,7 @@ - + @@ -516,7 +516,7 @@ - + @@ -525,7 +525,7 @@ - + @@ -539,13 +539,13 @@ - + - + diff --git a/platforms/Windows/cli/asserts/cli.asserts.wixproj b/platforms/Windows/cli/asserts/cli.asserts.wixproj index 2a3c0750..3c4d0bd9 100644 --- a/platforms/Windows/cli/asserts/cli.asserts.wixproj +++ b/platforms/Windows/cli/asserts/cli.asserts.wixproj @@ -17,7 +17,7 @@ DocCRender_asserts - toolchains_asserts_usr_share_docc_render + toolchain_asserts_usr_share_docc_render var.SWIFT_DOCC_RENDER_ARTIFACT_ROOT_DIST true true diff --git a/platforms/Windows/cli/cli.wxi b/platforms/Windows/cli/cli.wxi index 0a92edac..e44f5b68 100644 --- a/platforms/Windows/cli/cli.wxi +++ b/platforms/Windows/cli/cli.wxi @@ -16,33 +16,33 @@ - - - - + + + + - + - - + + - - - - - - - - - - + + + + + + + + + + - + @@ -56,12 +56,12 @@ - - + + - + @@ -94,12 +94,12 @@ - - + + - + @@ -111,12 +111,12 @@ - - + + - + @@ -131,7 +131,7 @@ - + @@ -146,13 +146,13 @@ - + - + @@ -167,7 +167,7 @@ - + @@ -182,7 +182,7 @@ - + @@ -197,12 +197,12 @@ - + - + @@ -414,7 +414,7 @@ - + @@ -425,7 +425,7 @@ - + @@ -439,7 +439,7 @@ - + @@ -453,7 +453,7 @@ - + @@ -545,7 +545,7 @@ - + @@ -559,7 +559,7 @@ - + @@ -574,7 +574,7 @@ - + @@ -655,7 +655,7 @@ - + @@ -719,7 +719,7 @@ - + @@ -727,7 +727,7 @@ - + diff --git a/platforms/Windows/dbg/dbg.wxi b/platforms/Windows/dbg/dbg.wxi index f8a1e897..5185d705 100644 --- a/platforms/Windows/dbg/dbg.wxi +++ b/platforms/Windows/dbg/dbg.wxi @@ -16,117 +16,117 @@ - - + + - + - - - + + + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - - + + - + diff --git a/platforms/Windows/ide/ide.wxi b/platforms/Windows/ide/ide.wxi index 4ad5e146..0c36c0d3 100644 --- a/platforms/Windows/ide/ide.wxi +++ b/platforms/Windows/ide/ide.wxi @@ -16,45 +16,45 @@ - - + + - + - + - + - + - + - + - + - + diff --git a/platforms/Windows/shared/shared.wxs b/platforms/Windows/shared/shared.wxs index d261bf39..eda5b263 100644 --- a/platforms/Windows/shared/shared.wxs +++ b/platforms/Windows/shared/shared.wxs @@ -38,22 +38,22 @@ - - - - - - - - + + + + + + + + - - - + + + @@ -86,8 +86,8 @@ - - + + @@ -103,8 +103,8 @@ - - + + From e9c89e65c2edb6cdadc75993ff0d8d94b05e6f98 Mon Sep 17 00:00:00 2001 From: Mohamed Hegazy Date: Tue, 8 Jul 2025 14:51:56 -0700 Subject: [PATCH 4/4] Rebase after https://github.com/swiftlang/swift-installer-scripts/pull/419 --- platforms/Windows/bld/asserts/bld.asserts.wixproj | 2 +- platforms/Windows/shared/shared.wxs | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/platforms/Windows/bld/asserts/bld.asserts.wixproj b/platforms/Windows/bld/asserts/bld.asserts.wixproj index ccd7873a..7ef40f1f 100644 --- a/platforms/Windows/bld/asserts/bld.asserts.wixproj +++ b/platforms/Windows/bld/asserts/bld.asserts.wixproj @@ -39,7 +39,7 @@ SwiftStaticClangResources_asserts - _usr_lib_swift_static_clang + toolchain_asserts_usr_lib_swift_static_clang var._USR_LIB_SWIFT_STATIC_CLANG true true diff --git a/platforms/Windows/shared/shared.wxs b/platforms/Windows/shared/shared.wxs index eda5b263..1de7fcca 100644 --- a/platforms/Windows/shared/shared.wxs +++ b/platforms/Windows/shared/shared.wxs @@ -47,8 +47,8 @@ - - + +