use "startIndex" instead of "start" on public API

Author: QuietMisdreavus

Sources/Markdown/Block Nodes/Block Container Blocks/OrderedList.swift

@@ -37,15 +37,15 @@ public extension OrderedList {
     /// The default starting index in CommonMark is 1. In this case, clients may use the default
     /// ordered-list start index of their desired rendering format. For example, when rendering to
     /// HTML, clients may omit the `start` attribute of the rendered list when this returns 1.
-    var start: UInt {
+    var startIndex: UInt {
         get {
             guard case let .orderedList(start) = _data.raw.markup.data else {
                 fatalError("\(self) markup wrapped unexpected \(_data.raw)")
             }
             return start
         }
         set {
-            guard start != newValue else {
+            guard startIndex != newValue else {
                 return
             }
             _data = _data.replacingSelf(.orderedList(parsedRange: nil, _data.raw.markup.copyChildren(), startIndex: newValue))

Sources/Markdown/Walker/Walkers/MarkupTreeDumper.swift

@@ -190,8 +190,8 @@ struct MarkupTreeDumper: MarkupWalker {
     }
 
     mutating func visitOrderedList(_ orderedList: OrderedList) {
-        if orderedList.start != 1 {
-            dump(orderedList, customDescription: "start: \(orderedList.start)")
+        if orderedList.startIndex != 1 {
+            dump(orderedList, customDescription: "startIndex: \(orderedList.startIndex)")
         } else {
             defaultVisit(orderedList)
         }

Tests/MarkdownTests/Visitors/MarkupFormatterTests.swift

@@ -149,23 +149,23 @@ class MarkupFormatterSingleElementTests: XCTestCase {
         do { // no checkbox
             let expected = "2. A list item."
             var renderedList = OrderedList(ListItem(Paragraph(Text("A list item."))))
-            renderedList.start = 2
+            renderedList.startIndex = 2
             let printed = renderedList.format(options: options)
             XCTAssertEqual(expected, printed)
         }
         do { // unchecked
             let expected = "2. [ ] A list item."
             var renderedList = OrderedList(ListItem(checkbox: .unchecked,
                                                     Paragraph(Text("A list item."))))
-            renderedList.start = 2
+            renderedList.startIndex = 2
             let printed = renderedList.format(options: options)
             XCTAssertEqual(expected, printed)
         }
         do { // checked
             let expected = "2. [x] A list item."
             var renderedList = OrderedList(ListItem(checkbox: .checked,
                                                     Paragraph(Text("A list item."))))
-            renderedList.start = 2
+            renderedList.startIndex = 2
             let printed = renderedList.format(options: options)
             XCTAssertEqual(expected, printed)
         }
@@ -944,7 +944,7 @@ class MarkupFormatterLineSplittingTests: XCTestCase {
 
         let expectedTreeDump = """
         Document
-        └─ OrderedList start: 1000
+        └─ OrderedList startIndex: 1000
            └─ ListItem
               └─ Paragraph
                  ├─ Text "Really really"

Tests/MarkdownTests/Visitors/MarkupTreeDumperTests.swift

@@ -55,7 +55,7 @@ final class MarkupTreeDumperTests: XCTestCase {
         ├─ BlockQuote @13:1-13:13 #38
         │  └─ Paragraph @13:3-13:13 #39
         │     └─ Text @13:3-13:13 #40 "BlockQuote"
-        ├─ OrderedList @15:1-17:1 #41 start: 2
+        ├─ OrderedList @15:1-17:1 #41 startIndex: 2
         │  ├─ ListItem @15:1-15:9 #42
         │  │  └─ Paragraph @15:4-15:9 #43
         │  │     └─ Text @15:4-15:9 #44 "flour"