Update for SE-0025 ('private' and 'fileprivate') #476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
Closed
| private var array: [Element] | ||
| private var set: Set<Element> | ||
| fileprivate var array: [Element] | ||
| fileprivate var set: Set<Element> |
There was a problem hiding this comment.
These probably shouldn't be required, but I will fix once this lands.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SE-0025 makes
privaterestrict access to a lexical scope; the Swift 2 behavior is now namedfileprivate. At the time of this pull request, the compiler treats bothprivateandfileprivateas havingfileprivatesemantics, but that will soon change.Supersedes #410; the latest amendment to SE-0025 permits some accesses that the original model (or at least our interpretation of it) would have forbidden. I made my changes by hand without compiler aid, though, so it's possible I missed a case.