From 0884922943daaad855b618e8b96313375a823d9b Mon Sep 17 00:00:00 2001 From: Ben Barham Date: Thu, 25 Apr 2024 14:42:41 -0700 Subject: [PATCH] [Build] Fix up the cmake build after swift-syntax was added Doesn't FetchContent when it isn't available right now, but we don't fetch any of the other required dependencies either. Can fix that when we fix them all. --- BuildSupport/SwiftSyntax/CMakeLists.txt | 14 ------------ CMakeLists.txt | 2 +- Sources/PackageModelSyntax/CMakeLists.txt | 26 ++++++----------------- 3 files changed, 7 insertions(+), 35 deletions(-) delete mode 100644 BuildSupport/SwiftSyntax/CMakeLists.txt diff --git a/BuildSupport/SwiftSyntax/CMakeLists.txt b/BuildSupport/SwiftSyntax/CMakeLists.txt deleted file mode 100644 index 09f4cd51d2c..00000000000 --- a/BuildSupport/SwiftSyntax/CMakeLists.txt +++ /dev/null @@ -1,14 +0,0 @@ -include(FetchContent) - -set(BUILD_SHARED_LIBS OFF) - -if(DEFINED SWIFTPM_PATH_TO_SWIFT_SYNTAX_SOURCE) - file(TO_CMAKE_PATH "${SWIFTPM_PATH_TO_SWIFT_SYNTAX_SOURCE}" swift_syntax_path) - FetchContent_Declare(SwiftSyntax - SOURCE_DIR "${swift_syntax_path}") -else() - FetchContent_Declare(SwiftSyntax - GIT_REPOSITORY https://github.com/apple/swift-syntax - GIT_TAG main) -endif() -FetchContent_MakeAvailable(SwiftSyntax) diff --git a/CMakeLists.txt b/CMakeLists.txt index 1a9153193ea..02431a09d49 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -45,6 +45,7 @@ if(FIND_PM_DEPS) find_package(SwiftASN1 CONFIG REQUIRED) find_package(SwiftCertificates CONFIG REQUIRED) find_package(SwiftCrypto CONFIG REQUIRED) + find_package(SwiftSyntax CONFIG REQUIRED) endif() find_package(dispatch QUIET) @@ -54,6 +55,5 @@ find_package(SQLite3 REQUIRED) # Enable `package` modifier for the whole package. add_compile_options("$<$:-package-name;SwiftPM>") -add_subdirectory(BuildSupport/SwiftSyntax) add_subdirectory(Sources) add_subdirectory(cmake/modules) diff --git a/Sources/PackageModelSyntax/CMakeLists.txt b/Sources/PackageModelSyntax/CMakeLists.txt index 556fd0c619b..cfab869efc1 100644 --- a/Sources/PackageModelSyntax/CMakeLists.txt +++ b/Sources/PackageModelSyntax/CMakeLists.txt @@ -24,12 +24,12 @@ target_link_libraries(PackageModelSyntax PUBLIC PackageLoading PackageModel - SwiftBasicFormat - SwiftDiagnostics - SwiftIDEUtils - SwiftParser - SwiftSyntax - SwiftSyntaxBuilder + SwiftSyntax::SwiftBasicFormat + SwiftSyntax::SwiftDiagnostics + SwiftSyntax::SwiftIDEUtils + SwiftSyntax::SwiftParser + SwiftSyntax::SwiftSyntax + SwiftSyntax::SwiftSyntaxBuilder ) # NOTE(compnerd) workaround for CMake not setting up include flags yet @@ -41,17 +41,3 @@ install(TARGETS PackageModelSyntax LIBRARY DESTINATION lib RUNTIME DESTINATION bin) set_property(GLOBAL APPEND PROPERTY SwiftPM_EXPORTS PackageModelSyntax) - -set(SWIFT_SYNTAX_MODULES - SwiftBasicFormat - SwiftParser - SwiftParserDiagnostics - SwiftDiagnostics - SwiftSyntax - SwiftSyntaxBuilder - SwiftIDEUtils -) -export(TARGETS ${SWIFT_SYNTAX_MODULES} - NAMESPACE SPMSwiftSyntax:: - FILE ${CMAKE_BINARY_DIR}/cmake/modules/SwiftSyntaxConfig.cmake - EXPORT_LINK_INTERFACE_LIBRARIES) \ No newline at end of file