Disable part of a test that fails with Swift Testing in the toolchain. #7885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove some assertions from `testSwiftTestXMLOutputWhenEmpty()` that aren't strictly necessary and which have started to fail as we add Swift Testing to the toolchain.
grynspan
added
bug
test suite
grynspan
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
francescomikulis,
xedin,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand and
owenv
as code owners
|
@swift-ci test |
bnbarham
approved these changes
Aug 16, 2024
grynspan
added a commit
that referenced
this pull request
Aug 20, 2024
xedin
added a commit
that referenced
this pull request
Aug 24, 2024
…oo… (#7914) …lchain. (#7901) (cherry picked from commit 5b6542d) **Explanation:** Disables a non-critical bit of a test that's now failing in CI due to the addition of Swift Testing. **Scope:** Bug fix in unit test. **Issue:** N/A **Original PR:** #7885 **Risk:** Low **Testing:** Self-testing. **Reviewer:** @MaxDesiatov @bnbarham @rintaro Co-authored-by: Jonathan Grynspan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove some assertions from
testSwiftTestXMLOutputWhenEmpty()that aren't strictly necessary and which have started to fail as we add Swift Testing to the toolchain.