[PackageGraph/Build] Remove BuildTriple and its remaining uses
#7896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roduct/target names and dependencies
xedin
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
francescomikulis,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand and
owenv
as code owners
|
@swift-ci please test |
|
Looks like the logic that select a destination for test products is not quiet right, I'll look into that tomorrow. |
MaxDesiatov
approved these changes
Aug 20, 2024
Update tests to remove `BuildTriple` use and replace it with `BuildParameters.Destination`
…oduct to infer destination When there are multiple packages involved, they are going to introduce mutliple `<package-name>PackageTests` products. While inferring a destination for a module we need to find the product it belongs to and infer based on whether that product has any direct macro dependencies or not.
xedin
force-pushed
the
hasta-la-vista-buildTriple
branch
from
55212c6 to
e81a40f
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
|
@swift-ci please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Last uses of
BuildTriplehave been removed which means that there are no more recursive graph updates or duplicate targets.Modifications:
BuildTripletypebuildTripleproperties fromResolved{Product, Module}types and all of the recursive update logic associated with themBuildOperationto detect destination for products and modules if one wasn't provided by the caller. Only ambiguity here are tests but the rule is clear - direct macro dependencies cause all tests to be build for the "host".Result:
Hasta la vista,
BuildTriple.