Skip to content

[6.2] Use the entire SHA-256 hash as an exit test ID. #1058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2025
Merged

[6.2] Use the entire SHA-256 hash as an exit test ID. #1058

merged 1 commit into from
Apr 8, 2025
+41 −32

Conversation

grynspan
Copy link
Contributor

@grynspan grynspan commented Apr 7, 2025

@grynspan
Use the entire SHA-256 hash as an exit test ID. (#1053)
479718a 
This PR uses the entire 256 bits of the computed SHA-256 hash for an
exit test's ID, not just the first 128. They're there, might as well use
them.

### Checklist:

- [x] Code and documentation should follow the style of the [Style
Guide](https://github.com/apple/swift-testing/blob/main/Documentation/StyleGuide.md).
- [x] If public symbols are renamed or modified, DocC references should
be updated.
@grynspan grynspan added enhancement New feature or request exit-tests ☠️ Work related to exit tests macros 🔭 Related to Swift macros such as @Test or #expect labels Apr 7, 2025
@grynspan grynspan added this to the Swift 6.2 milestone Apr 7, 2025
@grynspan grynspan self-assigned this Apr 7, 2025
@grynspan
Copy link
Contributor Author

grynspan commented Apr 7, 2025

@swift-ci test

@grynspan grynspan merged commit 3cd81d0 into release/6.2 Apr 8, 2025
3 checks passed
@grynspan grynspan deleted the jgrynspan/draw-the-rest-of-the-sha256-6.2 branch April 8, 2025 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briancroom briancroom briancroom approved these changes

@stmontgomery stmontgomery Awaiting requested review from stmontgomery stmontgomery is a code owner

@SeanROlszewski SeanROlszewski Awaiting requested review from SeanROlszewski

@suzannaratcliff suzannaratcliff Awaiting requested review from suzannaratcliff suzannaratcliff is a code owner

Assignees

@grynspan grynspan

Labels
enhancement New feature or request exit-tests ☠️ Work related to exit tests macros 🔭 Related to Swift macros such as @Test or #expect
Projects
None yet
Milestone
Swift 6.2
Development

Successfully merging this pull request may close these issues.
2 participants
@grynspan @briancroom