Skip to content

Add isFailure to Issue #1078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 14, 2025
Merged

Add isFailure to Issue #1078

merged 6 commits into from
Apr 14, 2025

Conversation

suzannaratcliff
Copy link
Contributor

Add isFailure var to Issue

Motivation:

This adds a variable to Issue in order to inspect if an issue isFailing. This will be nice when inspecting an issue after it is recorded.

Modifications:

  • Add isFailure variable
  • Update existing code to use isFailure

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

stmontgomery
stmontgomery reviewed Apr 14, 2025
View reviewed changes
stmontgomery
stmontgomery reviewed Apr 14, 2025
View reviewed changes
@suzannaratcliff
Copy link
Contributor Author

@swift-ci please test

stmontgomery
stmontgomery reviewed Apr 14, 2025
View reviewed changes
@grynspan grynspan added enhancement New feature or request issue-handling Related to Issue handling within the testing library labels Apr 14, 2025
@grynspan grynspan added this to the Swift 6.x milestone Apr 14, 2025
@suzannaratcliff
Copy link
Contributor Author

@swift-ci please test

@suzannaratcliff suzannaratcliff merged commit 72bed50 into swiftlang:main Apr 14, 2025
3 checks passed
@stmontgomery stmontgomery modified the milestones: Swift 6.x, Swift 6.2 Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stmontgomery stmontgomery stmontgomery approved these changes

@grynspan grynspan grynspan approved these changes

@briancroom briancroom Awaiting requested review from briancroom briancroom is a code owner

@SeanROlszewski SeanROlszewski Awaiting requested review from SeanROlszewski

Assignees

@suzannaratcliff suzannaratcliff

Labels
enhancement New feature or request issue-handling Related to Issue handling within the testing library
Projects
None yet
Milestone
Swift 6.2
Development

Successfully merging this pull request may close these issues.
3 participants
@suzannaratcliff @stmontgomery @grynspan