[Serialization] Invert order of diagnostics in forced recovery mode

Author: xymus

include/swift/AST/DiagnosticsSema.def

@@ -927,9 +927,9 @@ NOTE(modularization_issue_side_effect_type_error,none,
      "could not deserialize type for %0",
      (DeclName))
 
-WARNING(modularization_issue_worked_around,none,
-        "attempting forced recovery enabled by -experimental-force-workaround-broken-modules",
-        ())
+NOTE(modularization_issue_worked_around,none,
+     "attempting forced recovery enabled by -experimental-force-workaround-broken-modules",
+     ())
 
 ERROR(reserved_member_name,none,
       "type member must not be named %0, since it would conflict with the"

lib/Serialization/Deserialization.cpp

@@ -2147,13 +2147,13 @@ ModuleFile::resolveCrossReference(ModuleID MID, uint32_t pathLen) {
     if (getContext().LangOpts.ForceWorkaroundBrokenModules &&
         errorKind == ModularizationError::Kind::DeclMoved &&
         !values.empty()) {
-      // Print the error as a remark and notify of the recovery attempt.
-      getContext().Diags.diagnose(getSourceLoc(),
-                                  diag::modularization_issue_worked_around);
+      // Print the error as a warning and notify of the recovery attempt.
       llvm::handleAllErrors(std::move(error),
         [&](const ModularizationError &modularError) {
-          modularError.diagnose(this, DiagnosticBehavior::Note);
+          modularError.diagnose(this, DiagnosticBehavior::Warning);
         });
+      getContext().Diags.diagnose(getSourceLoc(),
+                                  diag::modularization_issue_worked_around);
     } else {
       return std::move(error);
     }

test/Serialization/modularization-error.swift

@@ -18,8 +18,18 @@
 // RUN: %target-swift-frontend -emit-sil %t/LibWithXRef.swiftmodule -module-name LibWithXRef -I %t \
 // RUN:   -experimental-force-workaround-broken-modules 2>&1 \
 // RUN:   | %FileCheck --check-prefixes CHECK-WORKAROUND %s
-// CHECK-WORKAROUND: warning: attempting forced recovery enabled by -experimental-force-workaround-broken-modules
-// CHECK-WORKAROUND: note: reference to type 'MyType' broken by a context change; 'MyType' was expected to be in 'A', but now a candidate is found only in 'B'
+// CHECK-WORKAROUND: warning: reference to type 'MyType' broken by a context change; 'MyType' was expected to be in 'A', but now a candidate is found only in 'B'
+// CHECK-WORKAROUND: A.MyType
+// CHECK-WORKAROUND: ^
+// CHECK-WORKAROUND: A.swiftmodule:1:1: note: declaration was expected to be found in this module
+// CHECK-WORKAROUND: <binary format>
+// CHECK-WORKAROUND: ^
+// CHECK-WORKAROUND: B.swiftmodule:1:1: note: declaration was found in this module
+// CHECK-WORKAROUND: <binary format>
+// CHECK-WORKAROUND: ^
+// CHECK-WORKAROUND: LibWithXRef.swiftmodule:1:1: note: attempting forced recovery enabled by -experimental-force-workaround-broken-modules
+// CHECK-WORKAROUND: <binary format>
+// CHECK-WORKAROUND: ^
 // CHECK-WORKAROUND: func foo() -> some Proto
 
 /// Change MyType into a function.