Add -sil-verify-all to tests. Removed unused convenience func

Author: elsh

include/swift/SIL/SILLinkage.h

@@ -278,14 +278,6 @@ inline bool isPossiblyUsedExternally(SILLinkage linkage, bool wholeModule) {
   llvm_unreachable("Unhandled SILLinkage in switch.");
 }
 
-inline bool isPublicOrPackage(SILLinkage linkage, int mode = 0) {
-  if (mode == 1) // non abi
-    return linkage == SILLinkage::PublicNonABI || linkage == SILLinkage::PackageNonABI;
-  if (mode == 2) // external
-    return linkage == SILLinkage::PublicExternal || linkage == SILLinkage::PackageExternal;
-  return linkage == SILLinkage::Public || linkage == SILLinkage::Package;
-}
-
 SILLinkage getDeclSILLinkage(const ValueDecl *decl);
 
 inline bool hasPublicVisibility(SILLinkage linkage) {

test/SILGen/package_sil_linkage.swift

@@ -11,11 +11,11 @@
 // RUN: %target-swift-frontend -typecheck %t/Client.swift -I %t -swift-version 5 -package-name mypkg -verify
 
 /// Check serialization in SILGEN with resilience enabled.
-// RUN: %target-swift-emit-silgen -emit-verbose-sil -enable-library-evolution -module-name Utils %t/Utils.swift -package-name mypkg -I %t > %t/Utils-Res.sil
+// RUN: %target-swift-emit-silgen -emit-verbose-sil -sil-verify-all -enable-library-evolution -module-name Utils %t/Utils.swift -package-name mypkg -I %t > %t/Utils-Res.sil
 // RUN: %FileCheck %s --check-prefixes=UTILS-RES,UTILS-COMMON < %t/Utils-Res.sil
 
 /// Check for indirect access with a resiliently built module dependency.
-// RUN: %target-swift-emit-silgen %t/Client.swift -package-name mypkg -I %t > %t/Client-Res.sil
+// RUN: %target-swift-emit-silgen -sil-verify-all %t/Client.swift -package-name mypkg -I %t > %t/Client-Res.sil
 // RUN: %FileCheck %s --check-prefixes=CLIENT-RES,CLIENT-COMMON < %t/Client-Res.sil
 
 // RUN: rm -rf %t/Utils.swiftmodule
@@ -29,11 +29,11 @@
 // RUN: %target-swift-frontend -typecheck %t/Client.swift -I %t -swift-version 5 -package-name mypkg -verify
 
 /// Check serialization in SILGEN with resilience not enabled.
-// RUN: %target-swift-emit-silgen -emit-verbose-sil -module-name Utils %t/Utils.swift -package-name mypkg -I %t > %t/Utils-NonRes.sil
+// RUN: %target-swift-emit-silgen -emit-verbose-sil -sil-verify-all -module-name Utils %t/Utils.swift -package-name mypkg -I %t > %t/Utils-NonRes.sil
 // RUN: %FileCheck %s --check-prefixes=UTILS-NONRES,UTILS-COMMON < %t/Utils-NonRes.sil
 
 /// Check for indirect access with a non-resiliently built module dependency.
-// RUN: %target-swift-emit-silgen %t/Client.swift -package-name mypkg -I %t > %t/Client-NonRes.sil
+// RUN: %target-swift-emit-silgen -sil-verify-all %t/Client.swift -package-name mypkg -I %t > %t/Client-NonRes.sil
 // RUN: %FileCheck %s --check-prefixes=CLIENT-NONRES,CLIENT-COMMON < %t/Client-NonRes.sil