Skip to content

Commit 6c7fc72

Browse files
committed
[nfc] remove outdated FIXME's
1 parent 6b3c795 commit 6c7fc72

File tree

2 files changed

+0
-4
lines changed

2 files changed

+0
-4
lines changed

lib/Sema/TypeCheckType.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2301,7 +2301,6 @@ bool TypeResolver::diagnoseMoveOnlyMissingOwnership(
23012301
diagnose(repr->getLoc(),
23022302
diag::moveonly_parameter_missing_ownership);
23032303

2304-
// FIXME: this should be 'borrowing'
23052304
diagnose(repr->getLoc(), diag::moveonly_parameter_ownership_suggestion,
23062305
"borrowing", "for an immutable reference")
23072306
.fixItInsert(repr->getStartLoc(), "borrowing ");
@@ -2310,7 +2309,6 @@ bool TypeResolver::diagnoseMoveOnlyMissingOwnership(
23102309
"inout", "for a mutable reference")
23112310
.fixItInsert(repr->getStartLoc(), "inout ");
23122311

2313-
// FIXME: this should be 'consuming'
23142312
diagnose(repr->getLoc(), diag::moveonly_parameter_ownership_suggestion,
23152313
"consuming", "to take the value from the caller")
23162314
.fixItInsert(repr->getStartLoc(), "consuming ");

test/Constraints/moveonly_constraints.swift

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -163,8 +163,6 @@ func checkCasting(_ b: any Box, _ mo: __shared MO, _ a: Any) {
163163
_ = a as MO // expected-error {{cannot convert value of type 'Any' to type 'MO' in coercion}}
164164
_ = b as MO // expected-error {{cannot convert value of type 'any Box' to type 'MO' in coercion}}
165165

166-
// FIXME(kavon): make sure at runtime these casts actually fail, or just make them errors? (rdar://104900293)
167-
168166
_ = MO() is AnyHashable // expected-warning {{cast from 'MO' to unrelated type 'AnyHashable' always fails}}
169167
// expected-error@-1 {{move-only types cannot be conditionally cast}}
170168
_ = MO() is AnyObject // expected-warning {{cast from 'MO' to unrelated type 'AnyObject' always fails}}

0 commit comments

Comments
 (0)