Merge pull request #35964 from zoecarver/cxx/another-double-add-fix

[cxx-interop] Skip already-imported sub decls.

Author: zoecarver

lib/ClangImporter/ImportDecl.cpp

@@ -3473,6 +3473,11 @@ namespace {
           }
         }
 
+        // If we've already imported this decl, skip it so we don't add the same
+        // member twice.
+        if (Impl.ImportedDecls.count({nd->getCanonicalDecl(), getVersion()}))
+          continue;
+
         auto member = Impl.importDecl(nd, getActiveSwiftVersion());
         if (!member) {
           if (!isa<clang::TypeDecl>(nd) && !isa<clang::FunctionDecl>(nd)) {
@@ -3485,11 +3490,6 @@ namespace {
         }
 
         if (auto nestedType = dyn_cast<TypeDecl>(member)) {
-          // Only import definitions. Otherwise, we might add the same member
-          // twice.
-          if (auto tagDecl = dyn_cast<clang::TagDecl>(nd))
-            if (tagDecl->getDefinition() != tagDecl)
-              continue;
           nestedTypes.push_back(nestedType);
           continue;
         }

test/Interop/Cxx/class/Inputs/nested-records.h

@@ -51,6 +51,18 @@ struct HasForwardDeclaredNestedType {
   struct ForwardDeclaredType { };
 };
 
+struct HasForwardDeclaredTemplateChild {
+  template <class T> struct ForwardDeclaredClassTemplate;
+  
+  struct DeclaresForwardDeclaredClassTemplateFriend {
+    template <class T>
+    friend struct HasForwardDeclaredTemplateChild::ForwardDeclaredClassTemplate;
+  };
+  
+  template <class T> struct ForwardDeclaredClassTemplate { };
+};
+
+
 // TODO: Nested class templates (SR-13853).
 
 #endif // TEST_INTEROP_CXX_CLASS_INPUTS_NESTED_RECORDS_H

test/Interop/Cxx/class/nested-records-module-interface.swift

@@ -57,10 +57,19 @@
 // CHECK: }
 
 // CHECK: struct HasForwardDeclaredNestedType {
+// CHECK:   struct ForwardDeclaredType {
+// CHECK:     init()
+// CHECK:   }
 // CHECK:   struct NormalSubType {
 // CHECK:     init()
 // CHECK:   }
-// CHECK:   struct ForwardDeclaredType {
+// CHECK:   init()
+// CHECK: }
+
+// CHECK: struct HasForwardDeclaredTemplateChild {
+// CHECK:   struct ForwardDeclaredClassTemplate<T> {
+// CHECK:   }
+// CHECK:   struct DeclaresForwardDeclaredClassTemplateFriend {
 // CHECK:     init()
 // CHECK:   }
 // CHECK:   init()