Merge pull request #31040 from apple/revert-30182-enum-cxx

Revert "Move out enum tests into a separate CXXInterop/enum directory"

Author: CodaFi

test/CXXInterop/enum/Inputs/enum-anon.h

@@ -45,6 +45,11 @@ module ctypes_bits_exported {
   export *
 }
 
+module EnumExhaustivity {
+  header "EnumExhaustivity.h"
+  export *
+}
+
 module ExternIntX { header "x.h" }
 
 module HasSubmodule {

test/CXXInterop/enum/Inputs/module.map

@@ -1,3 +1,24 @@
+enum {
+  Constant1,
+  Constant2
+};
+
+enum {
+  VarConstant1,
+  VarConstant2
+} global;
+
+typedef struct SR2511 {
+    int x;
+
+    enum {
+      SR2511A = 0, SR2511B, SR2511C
+    } y;
+
+    int z;
+} SR2511;
+
+#if __OBJC__
 enum : unsigned short {
   USConstant1,
   USConstant2
@@ -7,3 +28,4 @@ enum : unsigned short {
   USVarConstant1,
   USVarConstant2
 } usGlobal;
+#endif // __OBJC__

test/CXXInterop/enum/enum-anon.swift

@@ -1,7 +1,4 @@
-// RUN: %target-swift-frontend -emit-ir %s -I %S/Inputs | %FileCheck -check-prefix=CHECK %s
-// RUN: %target-swift-frontend -emit-ir %s -I %S/Inputs -enable-cxx-interop | %FileCheck -check-prefix=CHECK %s
-
-import EnumAnon
+// RUN: %target-swift-frontend -emit-ir %s -enable-objc-interop -import-objc-header %S/Inputs/enum-anon.h | %FileCheck -check-prefix=CHECK -check-prefix=CHECK-%target-runtime %s
 
 func verifyIsInt(_: inout Int) { }
 func verifyIsInt32(_: inout Int32) { }
@@ -26,6 +23,11 @@ public func testIR(x: UnsafePointer<SR2511>) -> CInt {
   // CHECK: store i32 1, i32* getelementptr inbounds ([[ENUM_TYPE]], [[ENUM_TYPE]]* bitcast (i32* @global to [[ENUM_TYPE]]*), i32 0, i32 0), align 4
   global = VarConstant2
 
+#if _runtime(_ObjC)
+  // CHECK-objc: store i16 1, i16* getelementptr inbounds (%Ts6UInt16V, %Ts6UInt16V* bitcast (i16* @usGlobal to %Ts6UInt16V*), i32 0, i32 0), align 2
+  usGlobal = USVarConstant2
+#endif
+
   // Force the definition of the type above.
   // CHECK: ret
   return x.pointee.z

test/CXXInterop/enum/Inputs/EnumExhaustivity.apinotes renamed to test/ClangImporter/Inputs/custom-modules/EnumExhaustivity.apinotes

@@ -1,10 +1,22 @@
 // RUN: %target-swift-frontend -typecheck %s -enable-objc-interop -import-objc-header %S/Inputs/enum-anon.h -DDIAGS -verify
 
-// REQUIRES: objc_interop
-
 func testDiags() {
+#if _runtime(_ObjC)
   let us2 = USConstant2
+#else
+  let us2: UInt16 = 0
+#endif
   let _: String = us2 // expected-error {{cannot convert value of type 'UInt16' to specified type 'String'}}
+
+#if _runtime(_ObjC)
   let usVar2 = USVarConstant2
+#else
+  let usVar2: UInt16 = 0
+#endif
   let _: String = usVar2 // expected-error {{cannot convert value of type 'UInt16' to specified type 'String'}}
+
+  // The nested anonymous enum value should still have top-level scope, because
+  // that's how C works. It should also have the same type as the field (above).
+  let _: String = SR2511.SR2511B // expected-error {{type 'SR2511' has no member 'SR2511B'}}
 }
+

test/CXXInterop/enum/Inputs/EnumExhaustivity.h renamed to test/ClangImporter/Inputs/custom-modules/EnumExhaustivity.h

@@ -1,4 +1,4 @@
-// RUN: %target-swift-frontend -emit-ir -primary-file %s -I %S/../../ClangImporter/Inputs/ -module-cache-path %t -enable-cxx-interop -o - | %FileCheck %s
+// RUN: %target-swift-frontend -emit-ir -primary-file %s -I %S/Inputs/custom-modules -module-cache-path %t -enable-cxx-interop -o - | %FileCheck %s
 
 import CXXInterop