[CSDiag] Don't increase candidate curry level if base is ignored #19934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `CandidateCalleeInfo` tries to create a candidate for expression in form of `<base>.<func>` it shouldn't assume that function type of '<func>' would always be at curry level 1, because base could be ignored when it is a module or 'b' refers to a static function. Resolves: rdar://problem/45242032
|
@swift-ci please smoke test |
rudkx
approved these changes
Oct 18, 2018
|
@swift-ci Thanks, will do! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
CandidateCalleeInfotries to create a candidate for expressionin form of
<base>.<func>it shouldn't assume that function type of'' would always be at curry level 1, because base could be ignored
when it is a module or 'b' refers to a static function.
Resolves: rdar://problem/45242032
Resolves: SR-8987